Repository navigation
test: strengthen ProfileExManager concurrency regression coverage - #10410
Open
aleksandr-miheichev wants to merge 1 commit into
Open
aleksandr-miheichev wants to merge 1 commit into
aleksandr-miheichev wants to merge 1 commit into
Conversation
aleksandr-miheichev
marked this pull request as ready for review
October 18, 2026 18:50
This was referenced Oct 18, 2026
aleksandr-miheichev
force-pushed
the
codex/fix-profile-ex-creation-race
branch
from
October 20, 2026 18:43
fa1ca2d to
2609f5a
Compare
aleksandr-miheichev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production fix proposed here has been merged in #10420. This PR is rebased onto that change and now adds regression coverage for concurrent first creation.
Synchronize workers before each new ID in
SetTestDelay_ShouldCreateOneEntryPerIndex. Add a mixed-setter test that checks delay, speed, message, IP information and sort are retained on one entry per ID. The final diff changes only the test file and preserves the production implementation accepted in #10420.Validation for
2609f5a:dotnet test --project ./v2rayN/ServiceLib.Tests -c Release -- --report-trx— 137 passed, 0 failed, 0 skipped.ProfileExManagerrestored to the parent of fix(profile-ex): 修复并发创建重复 ProfileExItem 的问题 #10420: both methods failed in 3/3 fresh processes, finding 27–37 entries instead of 10 and 226–274 instead of 100.