Skip to content

0 score not being passed back #70

Description

@kreut

Hi,

When a student receive a 0 and I pass the score back to Canvas, nothing actually gets passed back, making it look like it is something that needs to be graded (Bug report posted here: ).

As a possible fix, in https://github.com/IMSGlobal/lti-1-3-php-library/blob/master/src/lti/LTI_Grade.php:

$score_given = 0 + $this->score_given;
$grade_array = array_filter([
"scoreGiven" => $score_given,
"scoreMaximum" => 0 + $this->score_maximum,
"comment" => $this->comment,
"activityProgress" => $this->activity_progress,
"gradingProgress" => $this->grading_progress,
"timestamp" => $this->timestamp,
"userId" => $this->user_id,
"submissionReview" => $this->submission_review,
]);
if (!$score_given) {
$grade_array['scoreGiven'] = 0;
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions