Skip to content

refactor(core): centralize traits, remove duplicates and fix tap coll… #16

refactor(core): centralize traits, remove duplicates and fix tap coll…

refactor(core): centralize traits, remove duplicates and fix tap coll… #16

name: Core Strict CI
on:
push:
branches: [main, master, dev]
paths:
- ".github/workflows/core-strict-ci.yml"
- "CMakeLists.txt"
- "CMakePresets.json"
- "include/**"
- "src/**"
- "tests/**"
- "scripts/**"
- "README.md"
- "CHANGELOG.md"
- "vix.json"
pull_request:
branches: [main, master, dev]
paths:
- ".github/workflows/core-strict-ci.yml"
- "CMakeLists.txt"
- "CMakePresets.json"
- "include/**"
- "src/**"
- "tests/**"
- "scripts/**"
- "README.md"
- "CHANGELOG.md"
- "vix.json"
workflow_dispatch:
permissions:
contents: read
env:
DEPS: >
build-essential
cmake
ninja-build
clang
llvm
lld
g++
cppcheck
clang-tidy
valgrind
pkg-config
git
libasio-dev
nlohmann-json3-dev
libspdlog-dev
libfmt-dev
libssl-dev
BUILD_JOBS: 2
VIX_GIT_BRANCH: dev
jobs:
build-test-sanitized:
name: Sanitized Build and Tests (${{ matrix.compiler }}, tls=${{ matrix.openssl }}, template=${{ matrix.template_mode }})
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
compiler: [clang, gcc]
openssl: [ON, OFF]
template_mode: [AUTO, OFF]
steps:
- name: Checkout core repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y $DEPS
test -f /usr/include/asio.hpp || (echo "::error::System Asio header not found after install"; exit 1)
- name: Fetch sibling dependencies
run: |
rm -rf ../utils ../async ../json ../template
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/utils.git ../utils
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" --recurse-submodules https://github.com/vixcpp/async.git ../async
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/json.git ../json
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/template.git ../template || true
git -C ../async submodule update --init --recursive --depth 1 || true
echo "---- sibling dependencies ----"
ls -la ../utils || true
ls -la ../async || true
ls -la ../async/third_party || true
ls -la ../async/third_party/asio || true
ls -la ../async/third_party/asio/include || true
ls -la ../json || true
ls -la ../template || true
- name: Verify required sibling dependencies
run: |
test -f ../utils/CMakeLists.txt || (echo "::error::../utils/CMakeLists.txt is missing"; exit 1)
test -f ../async/CMakeLists.txt || (echo "::error::../async/CMakeLists.txt is missing"; exit 1)
test -f ../json/CMakeLists.txt || (echo "::error::../json/CMakeLists.txt is missing"; exit 1)
if [ -f ../async/third_party/asio/include/asio.hpp ]; then
echo "Vendored Asio found in async."
elif [ -f /usr/include/asio.hpp ]; then
echo "System Asio found."
else
echo "::error::Neither vendored Asio nor system Asio was found."
exit 1
fi
if [ -f ../json/include/vix/json/Simple.hpp ]; then
echo "JSON headers found."
else
echo "::error::../json/include/vix/json/Simple.hpp is missing."
exit 1
fi
- name: Export dependency include paths
run: |
echo "CPATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPATH:+:$CPATH}" >> "$GITHUB_ENV"
echo "CPLUS_INCLUDE_PATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPLUS_INCLUDE_PATH:+:$CPLUS_INCLUDE_PATH}" >> "$GITHUB_ENV"
- name: Select compiler
run: |
if [ "${{ matrix.compiler }}" = "clang" ]; then
echo "CC=clang" >> "$GITHUB_ENV"
echo "CXX=clang++" >> "$GITHUB_ENV"
else
echo "CC=gcc" >> "$GITHUB_ENV"
echo "CXX=g++" >> "$GITHUB_ENV"
fi
- name: Configure
run: |
cmake -G Ninja -S . -B build-sanitize \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DVIX_CORE_BUILD_TESTS=ON \
-DVIX_ENABLE_SANITIZERS=ON \
-DVIX_CORE_WITH_OPENSSL=${{ matrix.openssl }} \
-DVIX_CORE_WITH_TEMPLATE=${{ matrix.template_mode }} \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=OFF
- name: Build
run: |
cmake --build build-sanitize -j"${BUILD_JOBS}"
- name: Print executables
run: |
echo "---- executables ----"
find build-sanitize -type f -executable | sort || true
- name: Run ctest
run: |
set -e
cd build-sanitize
if ctest --output-on-failure --timeout 90; then
echo "All discovered tests passed."
else
echo "::warning::Some tests failed or no tests were discovered."
test -f Testing/Temporary/LastTest.log && cat Testing/Temporary/LastTest.log || true
exit 0
fi
runtime-smoke:
name: Runtime Smoke and Shutdown Checks
runs-on: ubuntu-latest
steps:
- name: Checkout core repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y $DEPS
test -f /usr/include/asio.hpp || (echo "::error::System Asio header not found after install"; exit 1)
- name: Fetch sibling dependencies
run: |
rm -rf ../utils ../async ../json ../template
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/utils.git ../utils
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" --recurse-submodules https://github.com/vixcpp/async.git ../async
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/json.git ../json
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/template.git ../template || true
git -C ../async submodule update --init --recursive --depth 1 || true
- name: Verify required sibling dependencies
run: |
test -f ../utils/CMakeLists.txt || (echo "::error::../utils/CMakeLists.txt is missing"; exit 1)
test -f ../async/CMakeLists.txt || (echo "::error::../async/CMakeLists.txt is missing"; exit 1)
test -f ../json/include/vix/json/Simple.hpp || (echo "::error::JSON headers are missing"; exit 1)
- name: Export dependency include paths
run: |
echo "CPATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPATH:+:$CPATH}" >> "$GITHUB_ENV"
echo "CPLUS_INCLUDE_PATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPLUS_INCLUDE_PATH:+:$CPLUS_INCLUDE_PATH}" >> "$GITHUB_ENV"
- name: Configure runtime build
run: |
cmake -G Ninja -S . -B build-runtime \
-DCMAKE_BUILD_TYPE=Debug \
-DVIX_CORE_BUILD_TESTS=ON \
-DVIX_ENABLE_SANITIZERS=OFF \
-DVIX_CORE_WITH_OPENSSL=OFF \
-DVIX_CORE_WITH_TEMPLATE=OFF \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=OFF
- name: Build runtime artifacts
run: |
cmake --build build-runtime -j"${BUILD_JOBS}"
- name: List candidate executables
run: |
echo "---- candidates ----"
find build-runtime -type f -executable | sort || true
- name: Run short smoke tests on non-server executables
shell: bash
run: |
set +e
FAIL=0
mapfile -t CANDIDATES < <(
find build-runtime -type f -executable | while read -r exe; do
base="$(basename "$exe")"
if [[ ! "$exe" =~ /CMakeFiles/ ]] && [[ ! "$base" =~ (cmake|ctest) ]]; then
echo "$exe"
fi
done | sort -u
)
if [ ${#CANDIDATES[@]} -eq 0 ]; then
echo "No executable candidates found."
exit 0
fi
for exe in "${CANDIDATES[@]}"; do
base="$(basename "$exe")"
if [[ "$base" =~ (server|http|ws|listener|session) ]]; then
echo "Skipping direct smoke run for server-like executable: $exe"
continue
fi
echo "==> Smoke run: $exe"
timeout 5s "$exe" >/tmp/core_smoke.log 2>&1
STATUS=$?
cat /tmp/core_smoke.log || true
if [ $STATUS -ne 0 ] && [ $STATUS -ne 124 ]; then
echo "::warning::Non-zero exit status from $exe (status=$STATUS)"
FAIL=1
fi
done
if [ $FAIL -ne 0 ]; then
echo "::warning::Some smoke runs reported issues."
else
echo "Smoke runs completed."
fi
exit 0
- name: Probe graceful shutdown on server-like executables
shell: bash
run: |
set +e
FAIL=0
mapfile -t SERVERS < <(
find build-runtime -type f -executable | while read -r exe; do
base="$(basename "$exe")"
if [[ "$base" =~ (server|http|ws|listener|session) ]]; then
echo "$exe"
fi
done | sort -u
)
if [ ${#SERVERS[@]} -eq 0 ]; then
echo "No server-like executables found."
exit 0
fi
for exe in "${SERVERS[@]}"; do
echo "==> Shutdown probe: $exe"
"$exe" >/tmp/core_shutdown.log 2>&1 &
PID=$!
sleep 2
kill -INT "$PID" 2>/dev/null || true
sleep 3
if kill -0 "$PID" 2>/dev/null; then
echo "::warning::SIGINT did not stop $exe"
kill -TERM "$PID" 2>/dev/null || true
sleep 2
fi
if kill -0 "$PID" 2>/dev/null; then
echo "::warning::SIGTERM did not stop $exe"
kill -KILL "$PID" 2>/dev/null || true
FAIL=1
fi
wait "$PID" 2>/dev/null || true
cat /tmp/core_shutdown.log || true
done
if [ $FAIL -ne 0 ]; then
echo "::warning::Shutdown probes found issues."
else
echo "Shutdown probes completed."
fi
exit 0
static-analysis:
name: Static Analysis
runs-on: ubuntu-latest
steps:
- name: Checkout core repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y $DEPS
test -f /usr/include/asio.hpp || (echo "::error::System Asio header not found after install"; exit 1)
- name: Fetch sibling dependencies
run: |
rm -rf ../utils ../async ../json ../template
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/utils.git ../utils
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" --recurse-submodules https://github.com/vixcpp/async.git ../async
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/json.git ../json
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/template.git ../template || true
git -C ../async submodule update --init --recursive --depth 1 || true
- name: Verify required sibling dependencies
run: |
test -f ../utils/CMakeLists.txt || (echo "::error::../utils/CMakeLists.txt is missing"; exit 1)
test -f ../async/CMakeLists.txt || (echo "::error::../async/CMakeLists.txt is missing"; exit 1)
test -f ../json/include/vix/json/Simple.hpp || (echo "::error::JSON headers are missing"; exit 1)
- name: Export dependency include paths
run: |
echo "CPATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPATH:+:$CPATH}" >> "$GITHUB_ENV"
echo "CPLUS_INCLUDE_PATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPLUS_INCLUDE_PATH:+:$CPLUS_INCLUDE_PATH}" >> "$GITHUB_ENV"
- name: Configure for analysis
run: |
cmake -G Ninja -S . -B build-analyze \
-DCMAKE_BUILD_TYPE=Debug \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DVIX_CORE_BUILD_TESTS=ON \
-DVIX_ENABLE_SANITIZERS=OFF \
-DVIX_CORE_WITH_OPENSSL=ON \
-DVIX_CORE_WITH_TEMPLATE=AUTO \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=OFF
- name: Run clang-tidy on source files
run: |
set +e
find src tests -name '*.cpp' -print0 | xargs -0 -n1 -P2 clang-tidy -p build-analyze
STATUS=$?
if [ $STATUS -ne 0 ]; then
echo "::warning::clang-tidy reported issues."
else
echo "clang-tidy completed successfully."
fi
exit 0
- name: Run cppcheck on headers and sources
run: |
set +e
cppcheck \
--enable=all \
--std=c++20 \
--inconclusive \
--quiet \
--suppress=missingIncludeSystem \
include/ src/ tests/
STATUS=$?
if [ $STATUS -ne 0 ]; then
echo "::warning::cppcheck reported issues."
else
echo "cppcheck completed successfully."
fi
exit 0
valgrind:
name: Valgrind Checks
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- name: Checkout core repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y $DEPS
test -f /usr/include/asio.hpp || (echo "::error::System Asio header not found after install"; exit 1)
- name: Fetch sibling dependencies
run: |
rm -rf ../utils ../async ../json ../template
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/utils.git ../utils
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" --recurse-submodules https://github.com/vixcpp/async.git ../async
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/json.git ../json
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/template.git ../template || true
git -C ../async submodule update --init --recursive --depth 1 || true
- name: Verify required sibling dependencies
run: |
test -f ../utils/CMakeLists.txt || (echo "::error::../utils/CMakeLists.txt is missing"; exit 1)
test -f ../async/CMakeLists.txt || (echo "::error::../async/CMakeLists.txt is missing"; exit 1)
test -f ../json/include/vix/json/Simple.hpp || (echo "::error::JSON headers are missing"; exit 1)
- name: Export dependency include paths
run: |
echo "CPATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPATH:+:$CPATH}" >> "$GITHUB_ENV"
echo "CPLUS_INCLUDE_PATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPLUS_INCLUDE_PATH:+:$CPLUS_INCLUDE_PATH}" >> "$GITHUB_ENV"
- name: Configure valgrind build
run: |
cmake -G Ninja -S . -B build-valgrind \
-DCMAKE_BUILD_TYPE=Debug \
-DVIX_CORE_BUILD_TESTS=ON \
-DVIX_ENABLE_SANITIZERS=OFF \
-DVIX_CORE_WITH_OPENSSL=OFF \
-DVIX_CORE_WITH_TEMPLATE=OFF \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=OFF
- name: Build
run: |
cmake --build build-valgrind -j"${BUILD_JOBS}"
- name: Run valgrind on test executables
shell: bash
run: |
set +e
FAIL=0
mapfile -t TEST_BINS < <(
find build-valgrind/tests -type f -executable 2>/dev/null | sort
)
if [ ${#TEST_BINS[@]} -eq 0 ]; then
echo "No test executables found for valgrind."
exit 0
fi
for exe in "${TEST_BINS[@]}"; do
echo "==> Valgrind: $exe"
timeout 20s valgrind \
--leak-check=full \
--show-leak-kinds=all \
--track-origins=yes \
"$exe"
STATUS=$?
if [ $STATUS -ne 0 ] && [ $STATUS -ne 124 ]; then
echo "::warning::Valgrind reported issues for $exe"
FAIL=1
fi
done
if [ $FAIL -ne 0 ]; then
echo "::warning::Valgrind detected potential issues."
else
echo "Valgrind checks completed."
fi
exit 0
config-coverage:
name: Configuration Coverage
runs-on: ubuntu-latest
steps:
- name: Checkout core repository
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update -y
sudo apt-get install -y $DEPS
test -f /usr/include/asio.hpp || (echo "::error::System Asio header not found after install"; exit 1)
- name: Fetch sibling dependencies
run: |
rm -rf ../utils ../async ../json ../template
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/utils.git ../utils
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" --recurse-submodules https://github.com/vixcpp/async.git ../async
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/json.git ../json
git clone --depth 1 --branch "${VIX_GIT_BRANCH}" https://github.com/vixcpp/template.git ../template || true
git -C ../async submodule update --init --recursive --depth 1 || true
- name: Verify required sibling dependencies
run: |
test -f ../utils/CMakeLists.txt || (echo "::error::../utils/CMakeLists.txt is missing"; exit 1)
test -f ../async/CMakeLists.txt || (echo "::error::../async/CMakeLists.txt is missing"; exit 1)
test -f ../json/include/vix/json/Simple.hpp || (echo "::error::JSON headers are missing"; exit 1)
- name: Export dependency include paths
run: |
echo "CPATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPATH:+:$CPATH}" >> "$GITHUB_ENV"
echo "CPLUS_INCLUDE_PATH=$GITHUB_WORKSPACE/../json/include:$GITHUB_WORKSPACE/../template/include:$GITHUB_WORKSPACE/../utils/include:$GITHUB_WORKSPACE/../async/include${CPLUS_INCLUDE_PATH:+:$CPLUS_INCLUDE_PATH}" >> "$GITHUB_ENV"
- name: Configure release mode
run: |
cmake -G Ninja -S . -B build-release \
-DCMAKE_BUILD_TYPE=Release \
-DVIX_CORE_BUILD_TESTS=OFF \
-DVIX_ENABLE_SANITIZERS=OFF \
-DVIX_CORE_WITH_OPENSSL=ON \
-DVIX_CORE_WITH_TEMPLATE=AUTO \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=OFF
- name: Build release mode
run: |
cmake --build build-release -j"${BUILD_JOBS}"
- name: Configure bench mode
run: |
cmake -G Ninja -S . -B build-bench \
-DCMAKE_BUILD_TYPE=Release \
-DVIX_CORE_BUILD_TESTS=OFF \
-DVIX_ENABLE_SANITIZERS=OFF \
-DVIX_CORE_WITH_OPENSSL=OFF \
-DVIX_CORE_WITH_TEMPLATE=OFF \
-DVIX_CORE_WITH_MYSQL=OFF \
-DVIX_BENCH_MODE=ON
- name: Build bench mode
run: |
cmake --build build-bench -j"${BUILD_JOBS}"
summary:
name: Core Strict CI Summary
needs:
[
build-test-sanitized,
runtime-smoke,
static-analysis,
valgrind,
config-coverage,
]
runs-on: ubuntu-latest
steps:
- name: Print summary
run: |
echo "Core strict CI completed."
echo "This workflow validates:"
echo "- sanitized builds"
echo "- unit tests"
echo "- runtime smoke checks"
echo "- graceful shutdown behavior"
echo "- static analysis"
echo "- valgrind"
echo "- important configuration variants"