Heads up: the CI workflow hasn't gone green on main yet. Its first run (113a0b2) failed on just test and just e2e, and since the clippy gate landed in 5ccc405 every push stops at just clippy instead (e2e is fine on the latest run).
I ran cargo clippy --workspace --all-targets locally on 1.97.1, without -D warnings so it gets past the first crate. Rough picture:
walgit-config lib 40 warnings
walgit-proto lib 27 warnings (19 of them in the generated walgit.v1.rs)
walgit-git lib 184 warnings, plus 40 to 113 per test binary
walgit-git test upload_gix_scale: 2 errors from undocumented_unsafe_blocks (deny)
walgit-wal, walgit-bundle, walgit-server, walgit-cli: not reached, the run stops at that error
Most of it is unwrap_used (129), doc_markdown (46), indexing_slicing (28), collapsible_if (25), string_slice (22), format_push_string (22) and redundant_closure (21), plus 14 of the Duration unit lint.
The practical problem is that every PR now gets a red check whatever it touches (mine included). Two ways to handle it, and I'm happy to do either:
- Keep the lint set and fix the code, one crate per PR. Mechanical, but it's a few hundred edits in walgit-git alone, so a fair amount of review on your side.
- Narrow the gate for now: allow pedantic on the generated proto module and set the noisiest pedantic lints to allow in
[workspace.lints.clippy] until the code catches up. That turns CI green today and the gate still catches new code.
Update: #15 already said the gate stays red until each crate's fixes land, so it's option 1. Progress, one crate per PR (checked when merged):
Heads up: the CI workflow hasn't gone green on
mainyet. Its first run (113a0b2) failed onjust testandjust e2e, and since the clippy gate landed in 5ccc405 every push stops atjust clippyinstead (e2e is fine on the latest run).I ran
cargo clippy --workspace --all-targetslocally on 1.97.1, without-D warningsso it gets past the first crate. Rough picture:Most of it is
unwrap_used(129),doc_markdown(46),indexing_slicing(28),collapsible_if(25),string_slice(22),format_push_string(22) andredundant_closure(21), plus 14 of theDurationunit lint.The practical problem is that every PR now gets a red check whatever it touches (mine included). Two ways to handle it, and I'm happy to do either:
[workspace.lints.clippy]until the code catches up. That turns CI green today and the gate still catches new code.Update: #15 already said the gate stays red until each crate's fixes land, so it's option 1. Progress, one crate per PR (checked when merged):
undocumented_unsafe_blockserrors intests/upload_gix_scale.rs. Biggest slice, probably two or three PRs. I can start after Fix the clippy pedantic warnings in walgit-config #28 unless someone else wants it.