Skip to content

Only include PRs that were merged #6

Description

@tmr08c

Sometimes a pull request will be closed, but not merged. We should filter out closed but not merged pull requests.

Possible Solutions

  1. Use the Pull Request endpoint instead (Use GitHub's Pull Request endpoint #8). The response from this endpoint as a merged_at field. Ideally, this would be empty or something when the PR hasn't been merged.
  2. Make an additional call to the Pull Request endpoint to check if merge (https://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged) for each PR we have.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions