[tests] Configure SQL Server the way PostgreSQL already is

The PostgreSQL URL has always been written into the test harness, so the
suite finds a local instance with no setup. SQL Server was the odd one
out: it read four environment variables, and its password defaulted to
empty, so prePublishPackage failed with 'Login failed for user sa'
unless you remembered to export them first.

The local instance is now spelled out alongside the PostgreSQL one, in
test/unit/common/other.ts, with the command that creates the container
in a comment beside it. The password belongs to a throwaway container
holding nothing but test data, and every part of the configuration can
still be pointed elsewhere with its variable.

The documentation examples keep reading TINYBASE_MSSQL rather than
spelling out credentials a reader might copy, which is the better thing
to show; the suite now supplies the local default when nothing else has,
so running them needs no setup either.

The whole persister and documentation suite, 3,541 tests, now passes
with no environment variables set at all.

Author: jamesgpearce

cspell.json

@@ -172,6 +172,7 @@
     "partyserver",
     "partysocket",
     "parvovirus",
+    "Passw",
     "passwordless",
     "Patryk",
     "Pearce",

test/unit/common/other.ts

@@ -15,6 +15,28 @@ export const withServers: boolean = isBun
   : (vitest as {inject?: (key: 'servers') => boolean}).inject?.('servers') ==
     true;
 
+// The local SQL Server these tests expect, given the same treatment as the
+// PostgreSQL URL in databases.ts. PostgreSQL can use trust authentication and
+// so needs no password; SQL Server cannot, so one is spelled out here. It is
+// the password of a throwaway container holding nothing but test data, never
+// a real instance:
+//
+//   docker run -d --name tinybase-mssql -p 1433:1433 \
+//     -e ACCEPT_EULA=Y -e MSSQL_PID=Developer \
+//     -e MSSQL_SA_PASSWORD='TinyBase!Passw0rd' \
+//     mcr.microsoft.com/mssql/server:2022-latest
+//
+// Point any part of it somewhere else with the matching variable.
+export const MSSQL_SERVER = process.env.TINYBASE_MSSQL_SERVER ?? 'localhost';
+export const MSSQL_PORT = Number(process.env.TINYBASE_MSSQL_PORT ?? 1433);
+export const MSSQL_USER = process.env.TINYBASE_MSSQL_USER ?? 'sa';
+export const MSSQL_PASSWORD =
+  process.env.TINYBASE_MSSQL_PASSWORD ?? 'TinyBase!Passw0rd';
+export const MSSQL_CONNECTION_STRING =
+  `Server=${MSSQL_SERVER},${MSSQL_PORT};Database=tinybase;` +
+  `User Id=${MSSQL_USER};Password=${MSSQL_PASSWORD};` +
+  `Encrypt=false;TrustServerCertificate=true`;
+
 export const AsyncFunction = Object.getPrototypeOf(
   async () => null,
 ).constructor;

test/unit/documentation.test.ts

@@ -8,7 +8,7 @@ import * as effectSchema from 'effect/Schema';
 import {build, transformSync} from 'esbuild';
 import 'fake-indexeddb/auto';
 import * as fs from 'fs';
-import {readFileSync, readdirSync} from 'fs';
+import {readdirSync, readFileSync} from 'fs';
 import {createRequire} from 'module';
 import * as mssql from 'mssql';
 import {dirname, extname, join, resolve} from 'path';
@@ -69,6 +69,7 @@ import {
   AsyncFunction,
   importBunSqlite,
   isBun,
+  MSSQL_CONNECTION_STRING,
   pause,
   suppressWarnings,
   withServers,
@@ -769,6 +770,11 @@ ${body
   expect(problem).toBeUndefined();
 };
 
+// The mssql examples deliberately read their connection string from the
+// environment rather than spelling out credentials a reader might copy. Point
+// it at the local instance when nothing else has, so the suite needs no setup.
+process.env.TINYBASE_MSSQL ??= MSSQL_CONNECTION_STRING;
+
 describe('Documentation tests', () => {
   beforeAll(async () => {
     if (isBun) {

test/unit/persisters/common/databases.ts

@@ -35,6 +35,10 @@ import {createSqliteWasmPersister} from 'tinybase/persisters/persister-sqlite-wa
 import tmp from 'tmp';
 import {afterAll, expect} from 'vitest';
 import {
+  MSSQL_PASSWORD,
+  MSSQL_PORT,
+  MSSQL_SERVER,
+  MSSQL_USER,
   importBunSqlite,
   isBun,
   noop,
@@ -76,14 +80,13 @@ const pgAdmin = async (sql: string) => {
   await adminPool.end();
 };
 
-// SQL Server needs credentials, so unlike the trust-authenticated PostgreSQL
-// above, these come from the environment rather than being hard-coded. Point
-// them at a scratch instance holding nothing but test data.
+// As with the PostgreSQL URL above, this is the local instance the tests
+// expect; see the constants in other.ts for what it is and how to override it.
 const getMsSqlConfig = (database: string) => ({
-  server: process.env.TINYBASE_MSSQL_SERVER ?? 'localhost',
-  port: Number(process.env.TINYBASE_MSSQL_PORT ?? 1433),
-  user: process.env.TINYBASE_MSSQL_USER ?? 'sa',
-  password: process.env.TINYBASE_MSSQL_PASSWORD ?? '',
+  server: MSSQL_SERVER,
+  port: MSSQL_PORT,
+  user: MSSQL_USER,
+  password: MSSQL_PASSWORD,
   database,
   pool: {max: 20},
   options: {encrypt: false, trustServerCertificate: true},