[sorter] More tests

Author: jamesgpearce

test/unit/core/other/indexes.test.ts

@@ -2031,6 +2031,11 @@ describe('Miscellaneous', () => {
     expect(getIndexesObject(indexes)['i1']).toBeUndefined();
   });
 
+  test('removes missing index definition', () => {
+    expect(indexes.delIndexDefinition('i1')).toBe(indexes);
+    expect(indexes.getIndexIds()).toEqual([]);
+  });
+
   test('destroys', () => {
     expect(indexes.getStore().getListenerStats().table).toEqual(0);
     expect(indexes.getStore().getListenerStats().row).toEqual(0);

test/unit/core/ui-react/hooks.test.tsx

@@ -2216,16 +2216,29 @@ describe('React-specific', () => {
             {JSON.stringify(
               useSortedRowIds({tableId: 't2', sorter: numericSorter}, store),
             )}
+            {JSON.stringify(
+              useSortedRowIds(
+                't2',
+                undefined,
+                undefined,
+                undefined,
+                undefined,
+                numericSorter,
+                store,
+              ),
+            )}
           </>,
         );
       const {container, unmount} = render(<Test />);
 
       expect(container.textContent).toEqual(
-        JSON.stringify(['0', '1', '2', '10']),
+        JSON.stringify(['0', '1', '2', '10']) +
+          JSON.stringify(['0', '1', '2', '10']),
       );
       act(() => store.setRow('t2', '3', {c1: true}));
       expect(container.textContent).toEqual(
-        JSON.stringify(['0', '1', '2', '3', '10']),
+        JSON.stringify(['0', '1', '2', '3', '10']) +
+          JSON.stringify(['0', '1', '2', '3', '10']),
       );
 
       unmount();
@@ -3814,6 +3827,33 @@ describe('React-specific', () => {
       unmount();
     });
 
+    test('useSortedRowIdsListener, object arg, custom sorter', () => {
+      expect.assertions(3);
+      const numericSorter = (sortKey1: any, sortKey2: any) =>
+        Number(sortKey1) - Number(sortKey2);
+      ['1', '10', '2'].forEach((rowId) =>
+        store.setRow('t2', rowId, {c1: true}),
+      );
+      const listener = vi.fn();
+      const Test = () => {
+        useSortedRowIdsListener(
+          {tableId: 't2', sorter: numericSorter},
+          listener,
+          [listener],
+          false,
+          store,
+        );
+        return <button />;
+      };
+      const {unmount} = render(<Test />);
+
+      store.setRow('t2', '3', {c1: true});
+      expect(listener).toHaveBeenCalledTimes(1);
+      expect(listener.mock.calls[0][6]).toEqual(['1', '2', '3', '10']);
+      unmount();
+      expect(store.getListenerStats().sortedRowIds).toEqual(0);
+    });
+
     test('useMetricListener (no deps)', () => {
       expect.assertions(4);
       const metrics = createMetrics(store).setMetricDefinition(

test/unit/core/ui-solid/primitives.test.ts

@@ -1479,8 +1479,8 @@ describe('Solid-specific', () => {
       positionalSortedRowIds = useSortedRowIds(
         't1',
         undefined,
-        false,
-        0,
+        undefined,
+        undefined,
         undefined,
         numericSorter,
         store,

test/unit/core/ui-svelte/components/FunctionSortedRowIdsObject.svelte

@@ -16,8 +16,8 @@
   const positionalRowIds = getSortedRowIds(
     't1',
     undefined,
-    false,
-    0,
+    () => undefined,
+    () => undefined,
     undefined,
     numericSorter,
     () => store,