From f6b1d2570370912dacd4aeae0c8b8d7c3401ed54 Mon Sep 17 00:00:00 2001 From: Afroz Mohiuddin Date: Sun, 29 Jun 2025 00:17:04 -0700 Subject: [PATCH] fix the implementation of the convolution --- autodiff_puzzlers.ipynb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/autodiff_puzzlers.ipynb b/autodiff_puzzlers.ipynb index 15ab52f..b0d9c95 100644 --- a/autodiff_puzzlers.ipynb +++ b/autodiff_puzzlers.ipynb @@ -4780,7 +4780,7 @@ "\n", "\n", "def f(x: Shaped[Array, \"I\"], y: Shaped[Array, \"W\"]) -> Shaped[Array, \"O\"]:\n", - " return np.convolve(x, y, mode=\"valid\") / W\n", + " return np.convolve(x, np.flip(y), mode=\"valid\") / W\n", "\n", "\n", "def jac(\n", @@ -7627,4 +7627,4 @@ }, "nbformat": 4, "nbformat_minor": 5 -} \ No newline at end of file +}