LT-22425: Fix testSetTextEmpty for Release builds (#847)

* LT-22425: Add a 1ms sleep to fix a test for release builds

Also:
* Run tests in a separate step for Installers and Patches
* Redirect all output to the log file, not just stdout
* Allow skipping managed tests from build.ps1

Author: papeh

.github/workflows/base-installer-cd.yml

@@ -152,11 +152,16 @@ jobs:
           echo "C:\Program Files (x86)\WiX Toolset v3.11\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
         if: github.event_name != 'pull_request'
 
-      - name: Build and test
-        id: build_and_test
+      - name: Build
+        id: build
         shell: powershell
         run: |
-          .\build.ps1 -BuildInstaller -Configuration Release -Verbosity detailed -RunTests -SkipNativeTests -TestFilter 'TestCategory!=DesktopRequired' -MsBuildArgs @("/bl") | Tee-Object -FilePath build.log
+          .\build.ps1 -BuildInstaller -Configuration Release -Verbosity detailed -BuildTests -MsBuildArgs @("/bl") *>&1 | Tee-Object -FilePath build.log
+
+      - name: Run tests
+        shell: powershell
+        run: |
+          .\test.ps1 -Configuration Release -NoBuild -TestFilter 'TestCategory!=DesktopRequired' *>&1 | Tee-Object -FilePath test.log
 
       - name: Scan Build Output
         shell: powershell

.github/workflows/patch-installer-cd.yml

@@ -220,12 +220,17 @@ jobs:
               New-ItemProperty -Path $path -Name $valueName -Value $expectedValue -Type String -Force
           }
 
-      - name: Build and test
-        id: build_and_test
+      - name: Build
+        id: build
         shell: powershell
         run: |
           Get-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\.NETFramework\AppContext"
-          .\build.ps1 -BuildPatch -Configuration Release -Verbosity detailed -RunTests -SkipNativeTests -TestFilter 'TestCategory!=DesktopRequired' -MsBuildArgs @("/bl") | Tee-Object -FilePath build.log
+          .\build.ps1 -BuildPatch -Configuration Release -Verbosity detailed -BuildTests -MsBuildArgs @("/bl") *>&1 | Tee-Object -FilePath build.log
+
+      - name: Run tests
+        shell: powershell
+        run: |
+          .\test.ps1 -Configuration Release -NoBuild -TestFilter 'TestCategory!=DesktopRequired' *>&1 | Tee-Object -FilePath test.log
 
       - name: Scan Build Output
         shell: powershell

Src/views/Test/TestVwTextStore.h

@@ -23,6 +23,9 @@ Last reviewed:
 
 #pragma once
 
+#include <chrono>
+#include <thread>
+
 #include "testViews.h"
 
 #if defined(_WIN32) || defined(_M_X64)
@@ -123,6 +126,7 @@ namespace TestViews
 	public:
 		MockTextStoreACPSink(ITextStoreACP * ptsa, IUnknown * punkOldSink)
 		{
+			this_thread::sleep_for(1ms); // testSetTextEmpty fails without this on Release builds but not Debug builds (discovered by LT-22425)
 			m_qtsa = ptsa;
 			if (punkOldSink)
 				CheckHr(ptsa->UnadviseSink(punkOldSink));
@@ -1834,7 +1838,9 @@ namespace TestViews
 		{
 			//_CrtSetDbgFlag(_CRTDBG_CHECK_ALWAYS_DF | _CRTDBG_DELAY_FREE_MEM_DF );
 			if (!m_fTestable)
+			{
 				return;
+			}
 			MakeStringList2();
 			Make2ParaSel(1, s_cchPara2, 2, 0);
 			TS_TEXTCHANGE ttc1 = { 0 };

build.ps1

@@ -165,6 +165,7 @@ param(
 	[switch]$SkipRestore,
 	[switch]$SkipNative,
 	[switch]$SkipNativeTests,
+	[switch]$SkipManagedTests,
 	[switch]$ForceBuildBuildTasks,
 	[switch]$BuildInstaller,
 	[switch]$BuildPatch,
@@ -718,6 +719,9 @@ try {
 		if ($SkipNative -or $SkipNativeTests) {
 			$testArgs["SkipNative"] = $true
 		}
+		if ($SkipManagedTests) {
+			$testArgs["SkipManaged"] = $true
+		}
 
 		Stop-ConflictingProcesses @cleanupArgs
 		& "$PSScriptRoot\test.ps1" @testArgs