Skip to content

Are self-approved PRs counted twice? #61

Description

@RalfJung

In Miri, I often self-approve PRs when I think they are sufficiently uncontroversial (which is most of them). The relevant commits and the bors commit with the approval then get synced to the rustc repo. If I understand the logic in this repo correctly, these PRs then count as one contribution by me for each commit, plus one contribution for the "review"? That doesn't seem entirely fair...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions