More linting with ruff?

[jschlyter]

I tried running ruff with some options that has been quite useful in other projects:

[tool.ruff]
lint.select = [
    # pycodestyle
    "E",
    # Pyflakes
    "F",
    # pyupgrade
    "UP",
    # flake8-bugbear
    "B",
    # flake8-simplify
    "SIM",
    # isort
    "I",
]
lint.ignore = ["E501", "E741", "F401", "I001", "SIM102"]
lint.exclude = ["tests/*"]

This results in some errors. Should I try to to fix them?

[jschlyter]

Examples:

B904 Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
SIM103 Return the condition `not t_version < t_minimum` directly
B904 Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling
UP032 [*] Use f-string instead of `format` call
UP031 Use format specifiers instead of percent format

Most of them can be fixed automatically by ruff.

[rthalley]

I will look at this config in detail and get back to you. I'm generally ok with more checking, and some of the changes it suggests are reasonable, however I don't like a lot of the "simplify" ones, in particular SIM108 which changes if ... else ... blocks into the ternary operator.

[rthalley]

After a bit more reading I'm inclined to adopt most of these but I think it's probably better if I do the edits, because I can group them into commits and we won't have any back and forth with me quibbling about which things I like and which I don't. Thanks for sending in the improved linting config!

(I'll convert this to an issue and assign to me)

[jschlyter]

See also #1110