fix(python): coerce dict retry config to Retry instance, fixing possible registration crash (#199)

GitOrigin-RevId: 3a493d288b2e428ee51e777dae3b62a5406f1ef5

Author: blue-keleher

python/render_sdk/workflows/task.py

@@ -23,6 +23,14 @@ class Retry:
     wait_duration_ms: int
     backoff_scaling: float = 1.5
 
+    @classmethod
+    def from_dict(cls, d: dict) -> "Retry":
+        return cls(
+            max_retries=d["max_retries"],
+            wait_duration_ms=d["wait_duration_ms"],
+            backoff_scaling=d["backoff_scaling"],
+        )
+
 
 @dataclass
 class Options:
@@ -39,6 +47,10 @@ class Options:
     timeout_seconds: int | None = None
     plan: str | None = None
 
+    def __post_init__(self):
+        if isinstance(self.retry, dict):
+            self.retry = Retry.from_dict(self.retry)
+
 
 @dataclass
 class ParameterInfo:

python/render_sdk/workflows/tests/test_end_to_end.py

@@ -190,6 +190,77 @@ def timeout_and_retry_task(x: int) -> int:
     assert combined_payload.options.retry.max_retries == 2
 
 
+def test_task_registration_with_dict_retry_config(
+    task_registry, task_decorator, mocker
+):
+    """
+    Test that registration handles dict retry configs passed to Options().
+    A caller may construct Options(retry={...}) with a plain dict instead
+    of a Retry instance. Options.__post_init__ should coerce it.
+    """
+    mock_uds_client_class = mocker.patch("render_sdk.workflows.runner.UDSClient")
+    mock_client_instance = mocker.Mock()
+    mock_uds_client_class.return_value = mock_client_instance
+    mock_client_instance.register_tasks = mocker.AsyncMock(
+        return_value={"status": "success"},
+    )
+    mock_client_instance.disconnect = mocker.AsyncMock()
+
+    # Options receives a plain dict instead of a Retry instance
+    dict_retry = {
+        "max_retries": 5,
+        "wait_duration_ms": 2000,
+        "backoff_scaling": 2.0,
+    }
+    options = Options(retry=dict_retry)
+
+    @task_decorator(options=options)
+    def my_task(x: int) -> int:
+        return x
+
+    mock_get_registry = mocker.patch("render_sdk.workflows.runner.get_task_registry")
+    mock_get_registry.return_value = task_registry
+
+    register("/tmp/test.sock")  # noqa:S108
+
+    sent_tasks = mock_client_instance.register_tasks.call_args[0][0]
+    task_payload = sent_tasks.tasks[0]
+
+    assert task_payload.options.retry.max_retries == 5
+    assert task_payload.options.retry.wait_duration_ms == 2000
+    assert task_payload.options.retry.factor == 2.0
+
+
+def test_task_registration_without_retry_config(task_registry, task_decorator, mocker):
+    """
+    Test that tasks with no retry config register successfully. This is the
+    common case that was unaffected by the dict retry bug.
+    """
+    from render_sdk.workflows.callback_api.types import UNSET
+
+    mock_uds_client_class = mocker.patch("render_sdk.workflows.runner.UDSClient")
+    mock_client_instance = mocker.Mock()
+    mock_uds_client_class.return_value = mock_client_instance
+    mock_client_instance.register_tasks = mocker.AsyncMock(
+        return_value={"status": "success"},
+    )
+    mock_client_instance.disconnect = mocker.AsyncMock()
+
+    @task_decorator
+    def my_task(x: int) -> int:
+        return x
+
+    mock_get_registry = mocker.patch("render_sdk.workflows.runner.get_task_registry")
+    mock_get_registry.return_value = task_registry
+
+    register("/tmp/test.sock")  # noqa:S108
+
+    sent_tasks = mock_client_instance.register_tasks.call_args[0][0]
+    task_payload = sent_tasks.tasks[0]
+
+    assert task_payload.options.retry is UNSET
+
+
 @pytest.mark.asyncio
 async def test_callback_payloads_with_mocked_client(
     task_registry,

python/render_sdk/workflows/tests/test_registration.py

@@ -119,6 +119,25 @@ def task_with_retry_only(x: int) -> int:
     assert retry_task.options.retry.max_retries == 1
 
 
+def test_options_coerces_dict_retry_to_retry():
+    """
+    Test that Options.__post_init__ coerces a dict retry config to a Retry instance.
+    """
+    options = Options(
+        retry={"max_retries": 5, "wait_duration_ms": 2000, "backoff_scaling": 2.0}
+    )
+    assert isinstance(options.retry, Retry)
+    assert options.retry.max_retries == 5
+    assert options.retry.wait_duration_ms == 2000
+    assert options.retry.backoff_scaling == 2.0
+
+
+def test_options_rejects_incomplete_dict_retry():
+    """Test that dict-to-Retry coercion raises KeyError for missing required keys."""
+    with pytest.raises(KeyError):
+        Options(retry={})
+
+
 def test_task_registration_preserves_function_attributes(task_registry, task_decorator):
     """Test that task registration preserves original function attributes."""