Declaration or Usages

[kuglee]

Could "Declaration or Usages" made to work with this plugin? I know that there's "LSP Reference(s)" but that works differently.

"Declaration or Usages" works like the following:

• middle-clicking a usage: goes to the declaration or shows a list of declarations when there's multiple candidates
• middle-clicking a declaration: shows a list of usages

Currently middle-clicking a usage works as expected but middle-clicking a declaration just goes to itself.

[angelozerr]

Implementing default menu is super hard because LSP doesn't work with PsiFile.

@SCWells72 have you some idea how to implement that?

[SCWells72]

Looking at declarationsOrReferences() in targets.kt, it appears that the primary issue is that LSP4IJ doesn't currently add PsiReferences which are used by gotoDeclarationOrUsages(). Basically if there are references that resolve to the offset, they're displayed for selection (unless there's exactly one reference in which case it's immediately navigated), and if not and there are references at the offset, they're either presented or, if only one, resolved and navigated.

I believe that to address this, actual references would have to be added to the PSI file.

[ericdallo]

@angelozerr given this is the most upvoted discussion, should we create a issue for it? at least for clojure-lsp-intellij, there is some noise of people requesting this feature

[angelozerr]

@ericdallo is this the same issue than #531 ?

[SCWells72]

I have a pending fix for this as part of the work for #98. See the demo I posted yesterday:

#98 (comment)

[ericdallo]

@angelozerr I think so, maybe we should rename the issue?

[SCWells72]

PR for this is now open as #853.

[angelozerr]

@kuglee @ericdallo could you install https://github.com/redhat-developer/lsp4ij?tab=readme-ov-file#testing-nightly-builds and tell me if it works better.

The nighty countains the 2 PRs from @SCWells72 which should fix this issue (if your language server supports semantic tokens) and provide breadcrumbs / line sticky.

[kuglee]

It's the same for me with 0.11.1-20250311-215653. I don't really know if it it supposed to work with sourcekit-lsp.
"Find usages" works but "Declaration or Usages" doesn't.

[SCWells72]

I'm sure it's something with my changes. To be clear, it's the standard IDE Go to Declaration or Usages that's not working here, correct? And specifically against sourcekit-lsp? Can you provide an example file and use case?

[angelozerr]

I'm sure it's something with my changes.

No I don't think so.

To be clear, it's the standard IDE Go to Declaration or Usages that's not working here, correct? And specifically against sourcekit-lsp? Can you provide an example file and use case?

It is the same thing for other language servers. When you do IDE Go to Declaration or Usages, the declaration is working, but it never execute Usages.

[angelozerr]

Oh sorry, it works wit TypeScript by using

let a = "1";

console.log(a)
console.log(a)

[angelozerr]

Ok I am not sure but I think there is a bug with dynamic registration of semantic capability. It seems SourceKit-LSP uses that and there is no semantic tokens. It will explain why it does not work.

[SCWells72]

If this is working with TypeScript but not with sourcekit-lsp, it may be that that language server is not designating declaration/definition semantic tokens as such. That's how the "or Usages" part works here...it needs to know that a semantic token is a declaration/definition so that it can report it as being a name identifier.

In the environment where this is not working, can you please share the output of the semantic tokens inspector with both tokens and modifiers showing?

[angelozerr]

@kuglee could you retry please.

First you should have semantic tokens (custom coloration) like this:

and I hope Usages will work.

[kuglee]

I've tried it with 0.12.0-20250313-173605. The Usages doesn't work. This is the result:

[angelozerr]

I'm not able to take a direct look right now, but the "Usages" portion will only work when the view provider has been populated with semantic tokens.

It is the case.

I haven't played with this particular language server, but it's possible that there's a lag in receiving semantic tokens and the user is trying to navigate from what will be reported as an identifier but has not yet been tagged as such. Just wanted to provide the quick thought on something that might explain the "working sometimes and sometimes not" behavior.

I have tested on my side and it is working, but I think it is another problem (I suspect a crash of sourcekit-lsp)

[angelozerr]

Yes.

Ok so it means that it is working and there is a problem with sourcekit-lsp. I have noticed that after some using of LSP request with sourcekit lsp, the server cancel any LSP request and nothing is working after that.

When it doesn't work, could you try to execute LSP references and check if it is working again.

[kuglee]

Thanks for the investigation. I don't know if the freezing with the nightlies are related to this issue, but I had to revert back to the latest release to actually be able to use this plugin.

[angelozerr]

Thanks for the investigation. I don't know if the freezing with the nightlies are related to this issue, but I had to revert back to the latest release to actually be able to use this plugin.

There is an issue with freeze
#878 that I am fixing and I will merge soon.

Let is wait for this merge and continue our discussion.

I dont understand your usecase to have this freeze?

Just doing ctrl+click on the a variable and sometimes it freezes?

[angelozerr]

Thanks for the investigation. I don't know if the freezing with the nightlies are related to this issue, but I had to revert back to the latest release to actually be able to use this plugin.

There is an issue with freeze
#878 that I am fixing and I will merge soon.

Let is wait for this merge and continue our discussion.

I dont understand your usecase to have this freeze?

Just doing ctrl+click on the a variable and sometimes it freezes?

Is there any chance to have a thread dumb when oiu have a freeze?

[angelozerr]

@kuglee you are using SourceKit LSP inside a custom IJ plugin?

[angelozerr]

@kuglee I have merged my PR which fixes a freeze issue. Could you re-install nighty build please.

You could have a freeze, but it should stop the freeze after 5000 ms.

Please give me feedback.

[SCWells72]

The IDE drops thread dumps automatically in the same directory as idea.log. Once the freeze has started, please use Help | Collect Logs and Diagnostic Data to collect diagnostics and attach them here, minimally the contents of the threadDumps-freeze-* directories that were generated after the freeze started. Those contain no sensitive data, only snapshots of the IDE's thread state.

[angelozerr]

0.12.0-20250315-115514

I've tried this on a real project. It was working for a while today. "Declaration or Usages" were working all the time.
Then I added some code and it started to freeze again. It didn't unfreeze after 5000 ms.

Here's the last log: freeze.log
And the thread dumps: threadDumps-freeze-20250316-160344-IU-243.25659.59.zip

Thanks so much to have taken your time to generate this thread dumb.

Let me investigate it.

[angelozerr]

0.12.0-20250315-115514

I've tried this on a real project. It was working for a while today. "Declaration or Usages" were working all the time.
Then I added some code and it started to freeze again. It didn't unfreeze after 5000 ms.

Here's the last log: freeze.log
And the thread dumps: threadDumps-freeze-20250316-160344-IU-243.25659.59.zip

Thanks so much to have taken your time to generate this thread dumb.

Let me investigate it.
https://github.com/redhat-developer/lsp4ij/actions/runs/13878580280 will be finished could you please reinstall the nighty.

@SCWells72 did a fix, if it doesnt work again we will do an another fix.

Thanks again for your patience and your help to test
@kuglee when

[SCWells72]

To be clear, this is a prospective fix based on what I've observed in the provided thread dumps. There's another class of potential issues identified by those thread dumps that could be the main contributor, but let's see whether this change helps or not.

[kuglee]

0.12.0-20250317-135348

The freezing issue happens with this version too. There wasn't anything interesting regarding lsp4ij in the idea.log this time.
TheadDumps: threadDumps-freeze-20250317-190136-IU-243.25659.59.zip

[angelozerr]

Thanks @kuglee ! I will investigate your problem once I will finish my other issues. @SCWells72 if you have time to investigate also the problem, you are welcome :)

[angelozerr]

@kuglee could you retry nighty build and tell us if it is working better please.

[kuglee]

0.12.0-20250322-135403

I'm currently using this version. So far no freezes. I'll keep testing for a few day and report back.

[kuglee]

I've jinxed it. I've just encountered a freeze:
threadDumps-freeze-20250323-201006-IU-243.26053.27.zip

[angelozerr]

LSP4IJ 0.12.0 has been released and should fix this Find usages issues.

Thanks again @kuglee to have spent so many times to test LSP4IJ 0.12.0 and helped me to discover a very annoying freeze.

[kuglee]

Thank you all for working on this.

[angelozerr]

@kuglee are you using the dap support for swift https://github.com/redhat-developer/lsp4ij/blob/main/docs%2Fdap%2Fuser-defined-dap%2Fswift-lldb.md ?

[kuglee]

I didn't set it up yet. Also I didn't know that there's a guide for Swift. Thanks

[angelozerr]

Any feedback are welcome!

[ericdallo]

just wanna share that 0.12.0 is working great with that feature in clojure-lsp-intellij, users are loving it!

[angelozerr]

Thanks @ericdallo for your nice feedback!

This feature comes from again from the amazing work of @SCWells72 !