The @custom:error tag convention was rejected in the PR #134 review: it has no precedent in the org, and error conditions are documented at their declarations (src/err/*) plus @dev prose on the functions that raise them. Two blocks landed on main before that ruling and were never swept:
The presence of these blocks is how the convention re-seeds itself — #194's author pattern-matched off the existing block. Task: convert any remaining @custom:error content into @dev prose (keeping only information not already at the error declarations) and remove the tags. Category-wide: the fix covers every @custom:error occurrence in src/, not just the sites listed. A follow-up lint banning the tag org-wide would live in rainix's static checks, not here.
🤖 Generated with Claude Code
The
@custom:errortag convention was rejected in the PR #134 review: it has no precedent in the org, and error conditions are documented at their declarations (src/err/*) plus@devprose on the functions that raise them. Two blocks landed on main before that ruling and were never swept:src/lib/op/LibOpFtsoCurrentPriceUsd.sol:39—@custom:error DecimalsTooLarge ...src/lib/op/LibOpFtsoCurrentPricePair.sol:48—@custom:error ... DivisionByZero ...(being removed by the docs(pair): clarify numerator/denominator naming and document error conditions #194 rework; listed for completeness)The presence of these blocks is how the convention re-seeds itself — #194's author pattern-matched off the existing block. Task: convert any remaining
@custom:errorcontent into@devprose (keeping only information not already at the error declarations) and remove the tags. Category-wide: the fix covers every@custom:erroroccurrence in src/, not just the sites listed. A follow-up lint banning the tag org-wide would live in rainix's static checks, not here.🤖 Generated with Claude Code