Updated rate service WSDL from v8 to v16, removed default setting of RequestedShipment.RateRequestTypes (no longer in WSDL), added better error messages for WSDL validation errors by passing suds' WebFault to SchemaValidationError

Author: foxxyz

fedex/base_service.py

@@ -41,9 +41,13 @@ class SchemaValidationError(FedexBaseServiceException):
     """
     Exception: There is probably a problem in the data you provided.
     """
-    def __init__(self):
+    def __init__(self, fault):
         self.error_code = -1
         self.value = "suds encountered an error validating your data against this service's WSDL schema. Please double-check for missing or invalid values, filling all required fields."
+        try:
+            self.value += ' Details: {}'.format(fault.detail.desc)
+        except AttributeError:
+            pass
 
 class FedexBaseService(object):
     """
@@ -212,11 +216,11 @@ def send_request(self, send_function=None):
             else:
                 # Default scenario, business as usual.
                 self.response = self._assemble_and_send_request()
-        except suds.WebFault:
+        except suds.WebFault as fault:
             # When this happens, throw an informative message reminding the
             # user to check all required variables, making sure they are
-            # populated and valid.
-            raise SchemaValidationError()
+            # populated and valid
+            raise SchemaValidationError(fault.fault)
 
         # Check the response for general Fedex errors/failures that aren't
         # specific to any given WSDL/request.

fedex/services/rate_service.py

@@ -25,14 +25,14 @@ def __init__(self, config_obj, *args, **kwargs):
         self._config_obj = config_obj
 
         # Holds version info for the VersionId SOAP object.
-        self._version_info = {'service_id': 'crs', 'major': '8', 
+        self._version_info = {'service_id': 'crs', 'major': '16', 
                              'intermediate': '0', 'minor': '0'}
 
         self.RequestedShipment = None
         """@ivar: Holds the RequestedShipment WSDL object."""
         # Call the parent FedexBaseService class for basic setup work.
         super(FedexRateServiceRequest, self).__init__(self._config_obj, 
-                                                         'RateService_v8.wsdl',
+                                                         'RateService_v16.wsdl',
                                                          *args, **kwargs)
         self.ClientDetail.Region = config_obj.express_region_code
 
@@ -80,9 +80,6 @@ def _prepare_wsdl_objects(self):
         # Assume US.
         Payor.CountryCode = 'US'
 
-        # ACCOUNT or LIST
-        self.RequestedShipment.RateRequestTypes = ['ACCOUNT'] 
-        
         # Start with no packages, user must add them.
         self.RequestedShipment.PackageCount = 0
         self.RequestedShipment.RequestedPackageLineItems = []