Expand {root} macros (#4145)

See #3842.

Author: SteffenDE

lib/phoenix_live_view/tag_engine/compiler.ex

@@ -527,7 +527,11 @@ defmodule Phoenix.LiveView.TagEngine.Compiler do
   defp handle_tag_attrs(meta, attrs, substate, state) do
     Enum.reduce(attrs, substate, fn
       {:root, {:expr, _, _} = expr, _attr_meta}, substate ->
-        ast = parse_expr!(expr, state.file)
+        ast =
+          case parse_expr!(expr, state.file) do
+            {:@, _, _} = ast -> ast
+            ast -> expand_with_line(ast, meta[:line], state.caller)
+          end
 
         # If we have a map of literal keys, we unpack it as a list
         # to simplify the downstream check.

test/phoenix_live_view/html_engine_test.exs

@@ -45,6 +45,13 @@ defmodule Phoenix.LiveView.HTMLEngineTest do
     end
   end
 
+  defmacro test_attr_macro(a) do
+    case a do
+      :base -> quote do: [{"style", "display: flex;"}, {"other", "foo"}, {"another", @bar}]
+      _ -> quote do: a
+    end
+  end
+
   def assigns_component(assigns) do
     ~H"{inspect(Map.delete(assigns, :__changed__))}"
   end
@@ -217,6 +224,15 @@ defmodule Phoenix.LiveView.HTMLEngineTest do
 
     assert %Phoenix.LiveView.Rendered{static: ["<div", " d2=\"2\"", "></div>"]} =
              eval(template, assigns)
+
+    # macro is expanded
+    template = ~S|<div {test_attr_macro(:base)} />|
+
+    assert %Phoenix.LiveView.Rendered{static: ["<div style=\"", "\" other=\"foo\"", "></div>"]} =
+             eval(template, %{bar: "baz"})
+
+    assert render(template, %{bar: "baz"}) ==
+             ~S|<div style="display: flex;" other="foo" another="baz"></div>|
   end
 
   test "optimizes attributes with literal string values" do