Skip to content

Use the term "phetUserId" instead of "userId" in the code and in translations #479

Description

@jbphet

In #478 we updated Rosetta to use new login state type definitions from the website. The website now uses the term "phetUserId" instead of "userId". It would be nice to fully align the terminology in Rosetta, but it's a big effort because the term "userId" is using in the translated JSON files. For now, the term "phetUserId" is used in the client code, but we've left it as "userId" in the client-to-server API and in the server code. It would be nice to change it everywhere, including the JSON files, at some point to make the code more consistent and thus more maintainable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions