chore: cleanup, simplification

Author: spuckhafte

src/handlers/http/logstream.rs

@@ -84,9 +84,7 @@ pub async fn delete(stream_name: Path<String>) -> Result<impl Responder, StreamE
     // clear filters associated to the deleted logstream
     delete_zombie_filters(&stream_name)
         .await
-        .map_err(|err| {
-            StreamError::Anyhow(anyhow::Error::msg(err.to_string()))
-        })?;
+        .map_err(|e| StreamError::Anyhow(anyhow::anyhow!(e)))?;
 
     Ok((format!("log stream {stream_name} deleted"), StatusCode::OK))
 }

src/handlers/http/modal/utils/logstream_utils.rs

@@ -117,12 +117,12 @@ pub async fn delete_zombie_filters(stream_name: &str) -> Result<(), ZombieFilter
                 stream_name,
                 err 
             );
-        }
-
-        if let Some(filter_id) = filter.filter_id.as_ref() {
-            FILTERS.delete_filter(filter_id).await;
+        } else { // ok: have the filter removed from memory only when the storage deletion succeeds
+            if let Some(filter_id) = filter.filter_id.as_ref() {
+                FILTERS.delete_filter(filter_id).await;
+            }
         }
     }
 
-    return Ok(());
+    Ok(())
 }