Replies: 1 comment
|
You weren't missing a local setup step: The invalid-hook-call failures came from tests calling These fixes were merged in react-hook-form/resolvers#854 and released in v5.4.3. That PR also restored the test step in CI; tests had not been running there since #699. For a new resolver contribution, start from current bun install
bun run test
bun lint
bun run buildCurrent CI is green with the test stage enabled, so rebasing away from |
Uh oh!
There was an error while loading. Please reload this page.
So I am trying to create a new resolver to handle ElysiaJS's extension of TypeBox schemas.
I could not get tests running in the @hookform/resolvers repo and eventually realised they will hang when using Vitest version 3.0.9 even though the package.json currently specifies:
"vitest": "^3.0.9",I can now get the tests to run using
bun run test(CONTRIBUTING.md currently saysbun testwhich does not work) but I get these results on tagv5.2.2:Many of these failing tests are due to the same underlying issue:
I am guessing bun has just installed the incorrect version of some testing package, but I can't really understand how these tests would ever pass in a development environment without the use of something like
renderHookfrom react-testing-library.Any help would be greatly appreciated, I'd love to contribute to this project.
All reactions