[Bug]: "magic numbers" when writing to temporary solid earth tide files as ENVI

[LiangJYu]

Checked for duplicates

Yes - I've already checked

Describe the bug

The temporary rdr2geo files are written to ENVI. Magic numbers at the head of the binary causes the files to be misread. Switch to tiff?

What did you expect?

Files to not be misread.

Reproducible steps

1.
2.
3.
...

Environment

- Version of this software [e.g. vX.Y.Z]
- Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
...

[seongsujeong]

Below are the lines where ENVI type was used:

%: git grep "ENVI"
src/compass/s1_geocode_metadata.py:    gdal_envi_driver = gdal.GetDriverByName('ENVI')
src/compass/s1_rdr2geo.py:        # save SLC to ENVI for all bursts
src/compass/s1_rdr2geo.py:                            rdr_grid.length, 1, dtype, 'ENVI')
src/compass/s1_resample.py:                                           'ENVI')
src/compass/utils/elevation_antenna_pattern.py:    drvout = gdal.GetDriverByName('ENVI')
src/compass/utils/helpers.py:        # GDAL reads 1st 2 bytes of ENVI binary to determine file type. If 1st
src/compass/utils/helpers.py:        # load as an ENVI file.
src/compass/utils/helpers.py:                         allowed_drivers=['ENVI'])
src/compass/utils/helpers.py:                 data_type=gdal.GDT_Float32, data_format='ENVI'):
src/compass/utils/lut.py:                        rdr_grid.length, 1, dtype, 'ENVI')
src/compass/utils/range_split_spectrum.py:    driver = gdal.GetDriverByName('ENVI')

[scottstanie]

same as #206, so any fix here will close that too

[seongsujeong]

@scottstanie Yes, I think the solution would be either replace ENVI file into something else, or use gdal.OpenEx() to force the format. I'll keep this in my TODO list.