Skip to content

Remove or implement dead CreateOptions.signers field #1004

Description

@eugenioenko

Description

CreateOptions.signers is part of the public OpenTDF.createTDF() API but is never read or forwarded. Supplying it has no runtime effect.

Assertion signing currently uses assertionConfigs[].signingKey. DPoP signing uses dpopKeys. The vendored JOSE helpers do not consume CreateOptions.signers.

Expected outcome

Choose one:

  • Remove CreateOptions.signers as dead API, with the appropriate compatibility plan.
  • Implement and document how signers maps into the TDF creation and assertion-signing flow.

Add coverage proving the selected behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions