Skip to content

Commit 2902922

Browse files
authored
OTA-1764: CVO: Add an Optional TLS Scanner Presubmit Job (#76044)
* cvo: Add optional tls scanner presubmit job A failing test of the tls-scanner-run step [1] does not fail the whole job [2]. At least, as of the moment. Thus, make the job optional. An always passing job has no significant value. Thus, the job is intended to be used to verify TLS changes explicitly. We'll depend on existing periodic testing and fix things when a regression is reported, if not caught during merging. Use an AWS cluster profile in combination with stronger compute nodes to handle the tls-scanner-run step. The default node type fails to schedule the needed pods by the step. The node type was chosen based on other tls-scanner jobs in the openshift/release repository. [1]: https://steps.ci.openshift.org/reference/tls-scanner-run [2]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/76044/rehearse-76044-pull-ci-openshift-cluster-version-operator-main-tls-scanner/2031796334276644864 * Run `make jobs`
1 parent ef870da commit 2902922

2 files changed

Lines changed: 92 additions & 0 deletions

File tree

ci-operator/config/openshift/cluster-version-operator/openshift-cluster-version-operator-main.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,17 @@ tests:
196196
container:
197197
from: src
198198
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
199+
- always_run: false
200+
as: tls-scanner
201+
optional: true
202+
steps:
203+
cluster_profile: aws-5
204+
env:
205+
COMPUTE_NODE_TYPE: m5.2xlarge
206+
SCAN_NAMESPACE: openshift-cluster-version
207+
test:
208+
- ref: tls-scanner-run
209+
workflow: ipi-aws
199210
zz_generated_metadata:
200211
branch: main
201212
org: openshift

ci-operator/jobs/openshift/cluster-version-operator/openshift-cluster-version-operator-main-presubmits.yaml

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1535,6 +1535,87 @@ presubmits:
15351535
secret:
15361536
secretName: result-aggregator
15371537
trigger: (?m)^/test( | .* )okd-scos-images,?($|\s.*)
1538+
- agent: kubernetes
1539+
always_run: false
1540+
branches:
1541+
- ^main$
1542+
- ^main-
1543+
cluster: build11
1544+
context: ci/prow/tls-scanner
1545+
decorate: true
1546+
labels:
1547+
ci-operator.openshift.io/cloud: aws
1548+
ci-operator.openshift.io/cloud-cluster-profile: aws-5
1549+
ci.openshift.io/generator: prowgen
1550+
pj-rehearse.openshift.io/can-be-rehearsed: "true"
1551+
name: pull-ci-openshift-cluster-version-operator-main-tls-scanner
1552+
optional: true
1553+
rerun_command: /test tls-scanner
1554+
spec:
1555+
containers:
1556+
- args:
1557+
- --gcs-upload-secret=/secrets/gcs/service-account.json
1558+
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
1559+
- --lease-server-credentials-file=/etc/boskos/credentials
1560+
- --report-credentials-file=/etc/report/credentials
1561+
- --secret-dir=/secrets/ci-pull-credentials
1562+
- --target=tls-scanner
1563+
command:
1564+
- ci-operator
1565+
env:
1566+
- name: HTTP_SERVER_IP
1567+
valueFrom:
1568+
fieldRef:
1569+
fieldPath: status.podIP
1570+
image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
1571+
imagePullPolicy: Always
1572+
name: ""
1573+
ports:
1574+
- containerPort: 8080
1575+
name: http
1576+
resources:
1577+
requests:
1578+
cpu: 10m
1579+
volumeMounts:
1580+
- mountPath: /etc/boskos
1581+
name: boskos
1582+
readOnly: true
1583+
- mountPath: /secrets/ci-pull-credentials
1584+
name: ci-pull-credentials
1585+
readOnly: true
1586+
- mountPath: /secrets/gcs
1587+
name: gcs-credentials
1588+
readOnly: true
1589+
- mountPath: /secrets/manifest-tool
1590+
name: manifest-tool-local-pusher
1591+
readOnly: true
1592+
- mountPath: /etc/pull-secret
1593+
name: pull-secret
1594+
readOnly: true
1595+
- mountPath: /etc/report
1596+
name: result-aggregator
1597+
readOnly: true
1598+
serviceAccountName: ci-operator
1599+
volumes:
1600+
- name: boskos
1601+
secret:
1602+
items:
1603+
- key: credentials
1604+
path: credentials
1605+
secretName: boskos-credentials
1606+
- name: ci-pull-credentials
1607+
secret:
1608+
secretName: ci-pull-credentials
1609+
- name: manifest-tool-local-pusher
1610+
secret:
1611+
secretName: manifest-tool-local-pusher
1612+
- name: pull-secret
1613+
secret:
1614+
secretName: registry-pull-credentials
1615+
- name: result-aggregator
1616+
secret:
1617+
secretName: result-aggregator
1618+
trigger: (?m)^/test( | .* )tls-scanner,?($|\s.*)
15381619
- agent: kubernetes
15391620
always_run: false
15401621
branches:

0 commit comments

Comments
 (0)