Skip to content

Use consistent status when approver does not find any jobs #375

@d3flex

Description

@d3flex

so I checked the code the only place where we really have different behavior based on suggested changes is in logging . Because in all other places "distinction" is wrapped back into boolean via check_status function .

So only real confusing which we would get is that when there is no jobs found in logs you will see in logs at least one failed job . Nevertheless this is confusing and might lead to false conclusions

Originally posted by @asmorodskyi in #374

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions