From a8e1cf7e31c3504d473f2f9ed78c51d67e0cb746 Mon Sep 17 00:00:00 2001 From: Florian Kotthoff <74312290+FlorianK13@users.noreply.github.com> Date: Fri, 25 Sep 2026 09:08:56 +0200 Subject: [PATCH 1/4] Fix misconfigured test #135 --- tests/headless/cli.test.ts | 51 +++++++++++++++++--------------------- 1 file changed, 23 insertions(+), 28 deletions(-) diff --git a/tests/headless/cli.test.ts b/tests/headless/cli.test.ts index e81c366..364ec96 100644 --- a/tests/headless/cli.test.ts +++ b/tests/headless/cli.test.ts @@ -15,34 +15,29 @@ describe('CLI integration test', () => { fs.rmSync(tempDir, { recursive: true, force: true }); }); - test( - 'run CLI as subprocess', - { timeout: 50000 }, - () => { - // Change working directory to base simshady directory - process.chdir(path.join(__dirname, '../..')); + test('run CLI as subprocess', { timeout: 50000 }, () => { + // Change working directory to base simshady directory + process.chdir(path.join(__dirname, '../..')); - // CLI needs to be built in order to test properly - const cliExists = fs.existsSync(path.join(__dirname, '/dist/cli.cjs')); - if (!cliExists) { - execSync('npm run build'); - } - try { - execSync( - `node dist/cli.cjs run ` + - `--simulation-geometry ${path.join(__dirname, 'data/building.obj')} ` + - `--irradiance-data ${path.join(__dirname, 'data/irradiance.json')} ` + - `--output-dir ${tempDir} ` + - `--silent`, - ); + // CLI needs to be built in order to test properly + const cliExists = fs.existsSync(path.join(__dirname, '/dist/cli.cjs')); + if (!cliExists) { + execSync('npm run build'); + } + try { + execSync( + `node dist/cli.cjs run ` + + `--simulation-geometry ${path.join(__dirname, 'data/building.obj')} ` + + `--irradiance-data ${path.join(__dirname, 'data/irradiance.json')} ` + + `--output-dir ${tempDir} ` + + `--silent`, + ); - // Check the output - expect(fs.existsSync(tempDir)).toBe(true); - } catch (error: any) { - console.error('CLI execution failed:', error.stdout, error.stderr); - throw error; - } - }, - 30000, - ); + // Check the output + expect(fs.existsSync(tempDir)).toBe(true); + } catch (error: any) { + console.error('CLI execution failed:', error.stdout, error.stderr); + throw error; + } + }); }); From 98c20a0bb28618eb692fd6c776289a2bbc37f197 Mon Sep 17 00:00:00 2001 From: Florian Kotthoff <74312290+FlorianK13@users.noreply.github.com> Date: Fri, 25 Sep 2026 09:10:07 +0200 Subject: [PATCH 2/4] Add docs test to CI pipeline #135 --- .github/workflows/tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1a28378..829769f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -32,6 +32,9 @@ jobs: - name: Build CLI package run: yarn build + - name: Build docs + run: yarn docs + - name: Run Vitest run: yarn test env: From dc5674c6d12c6555a24da25d7d6778d8fabc2f43 Mon Sep 17 00:00:00 2001 From: Florian Kotthoff <74312290+FlorianK13@users.noreply.github.com> Date: Fri, 25 Sep 2026 09:13:20 +0200 Subject: [PATCH 3/4] Update all github action versions --- .github/workflows/joss.yml | 4 ++-- .github/workflows/publish.yml | 4 ++-- .github/workflows/typedoc.yml | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/joss.yml b/.github/workflows/joss.yml index 0ed1307..9b8a5f3 100644 --- a/.github/workflows/joss.yml +++ b/.github/workflows/joss.yml @@ -8,14 +8,14 @@ jobs: name: Paper Draft steps: - name: Checkout - uses: actions/checkout@v4 + uses: actions/checkout@v7 - name: Build draft PDF uses: openjournals/openjournals-draft-action@master with: journal: joss paper-path: joss-paper/paper.md - name: Upload - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v7 with: name: paper path: joss-paper/paper.pdf diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 17c0518..c70991c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -11,9 +11,9 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v7 # Setup .npmrc file to publish to npm - - uses: actions/setup-node@v4 + - uses: actions/setup-node@v7 with: node-version: '20.x' registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/typedoc.yml b/.github/workflows/typedoc.yml index eef3567..912dbdb 100644 --- a/.github/workflows/typedoc.yml +++ b/.github/workflows/typedoc.yml @@ -14,13 +14,13 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - - uses: actions/setup-node@v4 + - uses: actions/checkout@v7 + - uses: actions/setup-node@v7 - run: yarn install --frozen-lockfile # Generate your TypeDoc documentation - run: yarn docs # https://github.com/actions/upload-pages-artifact - - uses: actions/upload-pages-artifact@v3 + - uses: actions/upload-pages-artifact@v5 with: path: ./docs # This should be your TypeDoc "out" path. @@ -34,4 +34,4 @@ jobs: - name: Deploy to GitHub Pages id: deployment # https://github.com/actions/deploy-pages - uses: actions/deploy-pages@v4 + uses: actions/deploy-pages@v5 From e92c6f6394f71655c6f166826f35da187b4b1224 Mon Sep 17 00:00:00 2001 From: Florian Kotthoff <74312290+FlorianK13@users.noreply.github.com> Date: Fri, 25 Sep 2026 09:18:02 +0200 Subject: [PATCH 4/4] Prepare release v0.2.4 --- CHANGELOG.md | 6 ++++++ package.json | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 00c051d..f233e71 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,12 @@ For each version important additions, changes and removals are listed here. The format is inspired from [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/v2.0.0.html). +## v0.2.4 - 2026-09-25 + +### Changes + +- Update github action versions by @FlorianK13 in https://github.com/open-pv/simshady/pull/136 + ## v0.2.3 - 2026-09-25 ### Changes diff --git a/package.json b/package.json index 3b61767..257f655 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@openpv/simshady", - "version": "0.2.3", + "version": "0.2.4", "description": "Simulating Shadows for PV Potential Analysis on 3D Data on the GPU.", "main": "./dist/index.js", "type": "module",