Adds new subcommand edit, adjust Justfile

Author: mvaltas

Justfile

@@ -1,28 +1,31 @@
-@test *options: format
-  uv run pytest {{options}}
+test *options:
+  DEVCLI_LOGLEVEL=debug uv run pytest {{options}}
 
-@lint:
-  uv run black . --check --diff --color
+lint:
+ uv run black . --check --diff --color
 
-@format:
-  uv run black .
+format:
+ uv run black .
 
-@update:
-  uv sync --upgrade
+update:
+ uv sync --upgrade
 
-@build:
-  uv build --wheel
+build:
+ uv build --wheel
 
-@install: build
-  pipx install --force dist/devcli*.whl
+install: build
+ pipx install --force dist/devcli*.whl
 
-@check: install
-  devcli example ping
-  -devcli show-version
-  -devcli show-config
+check: install
+ devcli example ping
+ -devcli show-version
+ -devcli show-config
 
-@bundle:
-  cd docs; bundle
+bundle:
+ cd docs; bundle
 
-@docs: bundle
+docs: bundle
   cd docs; rake
+
+@run +commands:
+  - uv run python bin/devcli {{commands}}

devcli/commands/edit.py

@@ -0,0 +1,52 @@
+import os
+from typer import Context
+from pathlib import Path
+
+import devcli.framework as cmd
+
+cli = cmd.new("Edit different files using text editor")
+
+logger = cmd.logger()
+
+# closure to create partial func
+def prep_editor(ctx: Context):
+    def run_editor(file: Path):
+        """Open editor on file"""
+        c_editor = ctx.obj["devcli.commands.edit.editor"]
+        e_editor = os.getenv("EDITOR", "vim")
+
+        # config first, env and last default
+        editor = c_editor if c_editor else e_editor
+
+        os.execvp(editor, [editor, file])
+
+    def open_editor(file: Path):
+        run_editor(file)
+
+    return open_editor
+
+
+@cli.command()
+def config(ctx: Context):
+    editor = prep_editor(ctx)
+    configs = ctx.obj.files()
+    if not configs:
+        cmd.stop("No configuration files were found.")
+
+    # last file is the most specific one
+    editor(configs[-1])
+
+
+@cli.command("command")
+def edit_command(ctx: Context, name: str):
+    editor = prep_editor(ctx)
+    configs = ctx.obj.files()
+    p = Path(configs[-1]).parent
+    subcmd = p / f"{name}.py"
+    logger.info(f"command search path: {subcmd}")
+    if subcmd.exists():
+        logger.info(f"command exists opening editor...")
+        editor(subcmd)
+    else:
+        logger.info(f"command does not exist in {subcmd}, stopping.")
+        cmd.stop(f"cmd: {subcmd.name} not found in path: {p}")

tests/commands/test_edit.py

@@ -1,11 +1,25 @@
 import pytest
 
+from unittest.mock import patch, ANY
+
+
+@pytest.fixture
+def mock_exec():
+    with patch("devcli.commands.edit.os.execvp") as mock:
+        yield mock
+
 
 @pytest.fixture(autouse=True)
 def setup(devcli_cmd):
     global edit
     edit = devcli_cmd("edit")
 
 
-def test_simple():
+def test_edit_config_calls_editor(mock_exec):
     result = edit("config")
+    mock_exec.assert_called_once_with("nvim", ["nvim", ANY])
+
+
+def test_edit_command_calls_editor(mock_exec):
+    result = edit("command", "placeholder")
+    mock_exec.assert_called_once_with("nvim", ["nvim", ANY])

tests/fixtures/placeholder.py

@@ -0,0 +1 @@
+# Just a place holder for 'edit command' test in test_edit.py