Fix network shutdown and leak regression gaps

Serialize WinRT status callbacks through the listener queue so Stop joins all event delivery, and replace timeout-based detachment with an explicit ready/failed startup state.

Honor IConnectionCost2 background restrictions, schedule weekly analysis, and compare all leak metrics with the reviewed cross-platform baseline using non-blocking warnings.

Files changed:
- .github/memory-leak-baseline.csv
- .github/scripts/run-drmemory.ps1
- .github/workflows/memory-leak-analysis.yml
- lib/pal/desktop/NetworkDetector.cpp
- lib/pal/desktop/NetworkDetector.hpp
- tests/unittests/NetworkDetectorTests.cpp

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: bmehta001

.github/memory-leak-baseline.csv

@@ -0,0 +1,7 @@
+Platform,Scenario,UniqueLeaks,TotalLeaks,LeakBytes,UniquePossibleLeaks,TotalPossibleLeaks,PossibleLeakBytes,UniqueReachable,TotalReachable,ReachableBytes
+Windows,unit-tests,10,113,4256,14,15,7206,467,644,227717
+Windows,functional-tests,7,382,14072,7,3994,1038248411,1722,2823,725167
+Windows,sample-cpp-mini,0,0,0,0,0,0,973,1795,411008
+Linux,unit-tests,10,127,3730,5,7,3452,8,8,77045
+Linux,functional-tests,3,156,4694,1,1,4104,360,643,279619
+Linux,sample-cpp-mini,1,2,32,0,0,0,15,23,81130

.github/scripts/run-drmemory.ps1

@@ -16,7 +16,9 @@ param(
     [ValidateNotNullOrEmpty()]
     [string]$TargetPath,
 
-    [string[]]$TargetArguments = @()
+    [string[]]$TargetArguments = @(),
+
+    [string]$BaselinePath
 )
 
 Set-StrictMode -Version Latest
@@ -100,10 +102,50 @@ else {
 }
 $summaries | Export-Csv -LiteralPath $summaryPath -NoTypeInformation
 
+$baselineStatus = "Not compared"
+if ($BaselinePath) {
+    $resolvedBaselinePath = (Resolve-Path -LiteralPath $BaselinePath).Path
+    $baselineRows = @(Import-Csv -LiteralPath $resolvedBaselinePath | Where-Object {
+        $_.Platform -eq $summary.Platform -and $_.Scenario -eq $summary.Scenario
+    })
+    if ($baselineRows.Count -ne 1) {
+        throw "Expected one baseline for $($summary.Platform)/$Scenario, found $($baselineRows.Count)."
+    }
+
+    $regressions = @()
+    foreach ($metric in @(
+        "UniqueLeaks",
+        "TotalLeaks",
+        "LeakBytes",
+        "UniquePossibleLeaks",
+        "TotalPossibleLeaks",
+        "PossibleLeakBytes",
+        "UniqueReachable",
+        "TotalReachable",
+        "ReachableBytes"
+    )) {
+        $currentValue = [int64]$summary.$metric
+        $baselineValue = [int64]$baselineRows[0].$metric
+        if ($currentValue -gt $baselineValue) {
+            $regressions += "$metric increased from $baselineValue to $currentValue"
+        }
+    }
+
+    if ($regressions.Count -eq 0) {
+        $baselineStatus = "At or below baseline"
+    }
+    else {
+        $baselineStatus = "$($regressions.Count) increase(s)"
+        foreach ($regression in $regressions) {
+            Write-Host "::warning title=Dr. Memory regression ($($summary.Platform)/$Scenario)::$regression"
+        }
+    }
+}
+
 $markdown = @"
-| Scenario | Unique leaks | Total leaks | Leak bytes | Unique possible | Possible bytes | Unique reachable | Reachable bytes |
-|---|---:|---:|---:|---:|---:|---:|---:|
-| $Scenario | $($leaks.Unique) | $($leaks.Total) | $($leaks.Bytes) | $($possibleLeaks.Unique) | $($possibleLeaks.Bytes) | $($reachable.Unique) | $($reachable.Bytes) |
+| Scenario | Unique leaks | Total leaks | Leak bytes | Unique possible | Possible bytes | Unique reachable | Reachable bytes | Baseline |
+|---|---:|---:|---:|---:|---:|---:|---:|---|
+| $Scenario | $($leaks.Unique) | $($leaks.Total) | $($leaks.Bytes) | $($possibleLeaks.Unique) | $($possibleLeaks.Bytes) | $($reachable.Unique) | $($reachable.Bytes) | $baselineStatus |
 "@
 Write-Host $markdown
 if ($env:GITHUB_STEP_SUMMARY) {

.github/workflows/memory-leak-analysis.yml

@@ -2,11 +2,14 @@ name: Memory leak analysis
 
 on:
   workflow_dispatch:
+  schedule:
+  - cron: 0 8 * * 1
   push:
     branches:
     - main
     paths:
     - .github/scripts/run-drmemory.ps1
+    - .github/memory-leak-baseline.csv
     - .github/workflows/memory-leak-analysis.yml
     - CMakeLists.txt
     - CMakePresets.json
@@ -25,6 +28,7 @@ on:
     - main
     paths:
     - .github/scripts/run-drmemory.ps1
+    - .github/memory-leak-baseline.csv
     - .github/workflows/memory-leak-analysis.yml
 
 permissions:
@@ -88,6 +92,7 @@ jobs:
         -LogDirectory drmemory-results
         -Scenario unit-tests
         -TargetPath Solutions/out/Debug/x64/UnitTests/UnitTests.exe
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetArguments "--gtest_filter=-OfflineStorageTests_SQLite.StoreThousandEventsTakesLessThanASecond"
 
     - name: Analyze functional tests
@@ -98,6 +103,7 @@ jobs:
         -LogDirectory drmemory-results
         -Scenario functional-tests
         -TargetPath Solutions/out/Debug/x64/FuncTests/FuncTests.exe
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetArguments "--gtest_filter=-BasicFuncTests.killSwitchWorks"
 
     - name: Analyze basic sample
@@ -107,6 +113,7 @@ jobs:
         -DrMemoryPath "$env:RUNNER_TEMP/DrMemory-Windows-$env:DRMEMORY_VERSION/bin64/drmemory.exe"
         -LogDirectory drmemory-results
         -Scenario sample-cpp-mini
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetPath Solutions/out/Debug/x64/SampleCppMini/SampleCppMini.exe
 
     - name: Verify Network List Manager is not loaded
@@ -186,6 +193,7 @@ jobs:
         -DrMemoryPath "$env:RUNNER_TEMP/DrMemory-Linux-$env:DRMEMORY_VERSION/bin64/drmemory"
         -LogDirectory drmemory-results
         -Scenario unit-tests
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetPath out/tests/unittests/UnitTests
 
     - name: Analyze functional tests
@@ -196,6 +204,7 @@ jobs:
         -LogDirectory drmemory-results
         -Scenario functional-tests
         -TargetPath out/tests/functests/FuncTests
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetArguments "--gtest_filter=-BasicFuncTests.killSwitchWorks"
 
     - name: Analyze basic sample
@@ -205,6 +214,7 @@ jobs:
         -DrMemoryPath "$env:RUNNER_TEMP/DrMemory-Linux-$env:DRMEMORY_VERSION/bin64/drmemory"
         -LogDirectory drmemory-results
         -Scenario sample-cpp-mini
+        -BaselinePath .github/memory-leak-baseline.csv
         -TargetPath out/sample-cpp-mini/SampleCppMini
 
     - name: Upload Linux reports