[Subscription Billing]Calculating initial dates correctly (#6352)

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->

This PR addresses two reported issues in Subscription Billing related to
incorrect or missing updates of subscription line dates (`Subscription
Line End Date` / `Service End Date`, `Term Until`, and `Cancellation
Possible Until`).

#### Fixed Issues

1. **Initial subscription dates not calculated correctly when
Subsequent/Extension Term is defined**
When posting Ship and Invoice from a Sales Order containing a
Subscription Item with both Initial Term and Subsequent Term filled, the
`Subscription Line Start Date` updated correctly, but `Service End Date`
and `Term Until` remained empty.
The root cause was logic that skipped initial end-date calculations when
a Subsequent/Extension Term existed.
Changes introduce a new internal procedure
`CalculateInitialSubscriptionDates()` in **Subscription Line** that
always calculates both `Service End Date` (via
`CalculateInitialServiceEndDate()`) and `Term Until` (via
`CalculateInitialTermUntilDate()`). Calls in **Sales Documents**,
**Create Subscription Line**, **Post Sub. Contract Renewal**, and
**Subscription Header** now use this consolidated procedure, ensuring
initial dates are set correctly regardless of Subsequent/Extension Term
presence.

2. **Cancellation Possible Until and Term Until not recalculated when
Service Start Date is modified**
On non-invoiced subscription lines (e.g., after "Extend Contract" or
manual edit), changing `Service Start Date` did not automatically update
`Cancellation Possible Until` or `Term Until`. The "Update Subscription
Line Dates" action also failed to update these fields.
   The refactor ensures consistent date recalculation:
- `CalculateInitialTermUntilDate()` now prioritizes existing
`Subscription Line End Date` when set and always updates `Cancellation
Possible Until` via `UpdateCancellationPossibleUntil()`.
- Consolidated initial date calculation improves reliability when start
dates change before invoicing.

#### Additional Improvements
- Simplified and standardized the `Extension Term` tooltip across
multiple pages (e.g., Service Commitments, Planned Service Commitments,
Customer Contract Lines) by removing outdated references to conditional
end-date setting, reflecting the new always-calculate-initial behavior.
- Added propagation of `Renewal Term` to **Sub. Contr. Analysis Entry**
for better data consistency in contract analysis.

These changes improve reliability of automatic date calculations, reduce
manual corrections, and align behavior with expected subscription
lifecycle rules without affecting existing renewal logic for subsequent
periods.

Technical code review from @samra-singhammer or @sit-zm required prior
to approval by Microsoft.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes #6132

[AB#620493](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/620493)

Author: miljance

src/Apps/W1/Subscription Billing/App/Billing/Codeunits/SalesDocuments.Codeunit.al

@@ -542,9 +542,7 @@ codeunit 8063 "Sales Documents"
                     SubscriptionLine.Validate("Calculation Base Amount", SubscriptionLine."Calculation Base Amount" * -1);
 
                 SubscriptionLine.UpdateNextPriceUpdate();
-                SubscriptionLine.CalculateInitialTermUntilDate();
-                SubscriptionLine.CalculateInitialServiceEndDate();
-                SubscriptionLine.CalculateInitialCancellationPossibleUntilDate();
+                SubscriptionLine.CalculateSubscriptionDates();
                 SubscriptionLine.SetCurrencyData(SalesHeader."Currency Factor", SalesHeader."Posting Date", SalesHeader."Currency Code");
                 SubscriptionLine.SetLCYFields(true);
                 if SalesLine."No." = SubscriptionLine."Invoicing Item No." then begin

src/Apps/W1/Subscription Billing/App/Contract Renewal/Codeunits/PostSubContractRenewal.Codeunit.al

@@ -107,9 +107,7 @@ codeunit 8004 "Post Sub. Contract Renewal"
             TempServiceCommitment."Subscription Line End Date" := CalcDate('<-1D>', TempServiceCommitment."Subscription Line End Date");
         end;
         TempServiceCommitment.CopyFromSalesServiceCommitment(SalesServiceCommitment);
-        TempServiceCommitment.CalculateInitialTermUntilDate();
-        TempServiceCommitment.CalculateInitialServiceEndDate();
-        TempServiceCommitment.CalculateInitialCancellationPossibleUntilDate();
+        TempServiceCommitment.CalculateSubscriptionDates();
         TempServiceCommitment.SetCurrencyData(SalesHeader."Currency Factor", SalesHeader."Posting Date", SalesHeader."Currency Code");
         TempServiceCommitment.SetLCYFields(true);
         TempServiceCommitment.SetDefaultDimensions(true);
@@ -274,7 +272,7 @@ codeunit 8004 "Post Sub. Contract Renewal"
     end;
 
     /// <summary>
-    /// Updates the existing subscription line from planned subscription line. It is used for subscription renewal.  
+    /// Updates the existing subscription line from planned subscription line. It is used for subscription renewal.
     /// </summary>
     /// <param name="PlannedServiceCommitment">Record "Planned Subscription Line".</param>
     procedure ProcessPlannedServiceCommitment(PlannedServiceCommitment: Record "Planned Subscription Line")

src/Apps/W1/Subscription Billing/App/Contract Renewal/Pages/PlannedServiceCommitments.Page.al

@@ -182,7 +182,7 @@ page 8004 "Planned Service Commitments"
                 }
                 field("Extension Term"; Rec."Extension Term")
                 {
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                 }
                 field("Cancellation Possible Until"; Rec."Cancellation Possible Until")
                 {

src/Apps/W1/Subscription Billing/App/ContractAnalysis/ContractAnalysisEntries.Page.al

@@ -142,7 +142,7 @@ page 8090 "Contract Analysis Entries"
                 }
                 field("Extension Term"; Rec."Extension Term")
                 {
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                 }
                 field("Billing Rhythm"; Rec."Billing Rhythm")
                 {

src/Apps/W1/Subscription Billing/App/ContractAnalysis/SubContrAnalysisEntry.Table.al

@@ -341,6 +341,7 @@ table 8019 "Sub. Contr. Analysis Entry"
         Rec."Currency Factor Date" := ServiceCommitment."Currency Factor Date";
         Rec."Extension Term" := ServiceCommitment."Extension Term";
         Rec."Initial Term" := ServiceCommitment."Initial Term";
+        Rec."Renewal Term" := ServiceCommitment."Renewal Term";
         Rec."Invoicing Item No." := ServiceCommitment."Invoicing Item No.";
         Rec."Next Billing Date" := ServiceCommitment."Next Billing Date";
         Rec."Notice Period" := ServiceCommitment."Notice Period";

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/ClosedCustContLineSubp.Page.al

@@ -239,7 +239,7 @@ page 8080 "Closed Cust. Cont. Line Subp."
                 field("Extension Term"; ServiceCommitment."Extension Term")
                 {
                     Caption = 'Subsequent Term';
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                     Editable = false;
                     Visible = false;
                 }

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/CustomerContractLineSubp.Page.al

@@ -386,7 +386,7 @@ page 8068 "Customer Contract Line Subp."
                 field("Extension Term"; ServiceCommitment."Extension Term")
                 {
                     Caption = 'Subsequent Term';
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                     Editable = false;
                     Visible = false;
                 }

src/Apps/W1/Subscription Billing/App/Customer Contracts/Pages/CustomerContractLines.Page.al

@@ -182,7 +182,7 @@ page 8075 "Customer Contract Lines"
                 field("Extension Term"; ServiceCommitment."Extension Term")
                 {
                     Caption = 'Subsequent Term';
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                 }
                 field("Billing Rhythm"; ServiceCommitment."Billing Rhythm")
                 {

src/Apps/W1/Subscription Billing/App/Import/Codeunits/CreateSubscriptionLine.Codeunit.al

@@ -118,10 +118,10 @@ codeunit 8006 "Create Subscription Line"
         if ImportedServiceCommitment."Calculation Base Amount (LCY)" <> 0 then
             ServiceCommitment."Calculation Base Amount (LCY)" := ImportedServiceCommitment."Calculation Base Amount (LCY)";
 
-        ServiceCommitment.CalculateInitialTermUntilDate();
         if ServiceCommitment."Subscription Line End Date" = 0D then
-            ServiceCommitment.CalculateInitialServiceEndDate();
-        ServiceCommitment.CalculateInitialCancellationPossibleUntilDate();
+            ServiceCommitment.CalculateSubscriptionDates()
+        else
+            ServiceCommitment.CalculateTermUntilDate();
 
         ServiceCommitment.SetDefaultDimensions(true);
         ServiceCommitment."Renewal Term" := ServiceCommitment."Initial Term";

src/Apps/W1/Subscription Billing/App/Import/Pages/ImportedServiceCommitments.Page.al

@@ -115,7 +115,7 @@ page 8009 "Imported Service Commitments"
                 }
                 field("Extension Term"; Rec."Extension Term")
                 {
-                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until". If the field is empty and the initial term or notice period is filled, the end of Subscription Line is automatically set to the end of the initial term or notice period.';
+                    ToolTip = 'Specifies a date formula for automatic renewal after initial term and the rhythm of the update of "Notice possible to" and "Term Until".';
                 }
                 field("Billing Rhythm"; Rec."Billing Rhythm")
                 {