From 8dd4b9c78c37009ddf5f334a89cc396c93772196 Mon Sep 17 00:00:00 2001 From: David Seguin Date: Tue, 13 Sep 2022 14:07:12 -0400 Subject: [PATCH 1/5] simple rtl --- README.md | 23 ++++++++++------------- src/components/musette/musette.scss | 10 +++++++--- 2 files changed, 17 insertions(+), 16 deletions(-) diff --git a/README.md b/README.md index 34f0e695..ac31ece0 100644 --- a/README.md +++ b/README.md @@ -9,16 +9,15 @@ # Table Of Contents - -- ### [What is Marble?](#What-is-Marble?) -- ### [Component Explorer](#Component-Explorer) -- ### [Design Documentation and Homepage](#Design-Documentation-and-Homepage) -- ### [Using Marble In Your Project](#Using-Marble-In-Your-Project) -- ### [How To Contribute To Marble](#Contributing-To-Marble) - - ### [Marble Development As A Local Package](#Marble-Development-As-A-Local-Package) - - ### [Storybook Development](#Storybook-Development) - - ### [Webpack Build for Release And Production](#[Webpack-Build-for-Release-And-Production) -- ### [Browsers We Support](#Browsers-We-Support) +- [What is Marble?](#What-is-Marble) +- [Component Explorer](#Component-Explorer) +- [Design Documentation and Homepage](#Design-Documentation-and-Homepage) +- [Using Marble In Your Project](#Using-Marble-In-Your-Project) +- [How To Contribute To Marble](#Contributing-To-Marble) + - [Marble Development As A Local Package](#Marble-Development-As-A-Local-Package) + - [Storybook Development](#Storybook-Development) + - [Webpack Build for Release And Production](#Webpack-Build-for-Release-And-Production) +- [Browsers We Support](#Browsers-We-Support) # What is Marble? @@ -32,7 +31,7 @@ Our component explorer, powered by [Storybook](https://storybook.js.org/docs/bas ## 🏛️ [main--5ef272f9ab690c0022ef30ab.chromatic.com](https://main--5ef272f9ab690c0022ef30ab.chromatic.com) 📙 -# Design Documentation and Homepage: +# Design Documentation and Homepage Marble's design docs and homepage are at: @@ -222,8 +221,6 @@ It is **not recommended** to point your installation of Marble to an environment # Contributing To Marble -# WIP - ## Conventions - mock your data separately diff --git a/src/components/musette/musette.scss b/src/components/musette/musette.scss index 522a92c0..a3c48bab 100644 --- a/src/components/musette/musette.scss +++ b/src/components/musette/musette.scss @@ -15,15 +15,15 @@ $button-height: 42px; width: 100%; } -.la-musette-offset > :first-child { +.la-musette--offset > :first-child { margin-left: 7.5vw; } -.la-musette-offset > :last-child { +.la-musette--offset > :last-child { margin-right: 7.5vw; } -.la-musette-no-scrollbar { +.la-musette--no-scrollbar { scrollbar-width: none; &::-webkit-scrollbar { @@ -31,6 +31,10 @@ $button-height: 42px; } } +.la-musette--rtl { + flex-direction: row-reverse; +} + //navigation .musette-move-left, .musette-move-right { From 4330d80fe3abe03f8a0ee0ed0f15ce6c1b19f78a Mon Sep 17 00:00:00 2001 From: davidseguin Date: Wed, 14 Sep 2022 14:23:29 -0400 Subject: [PATCH 2/5] DIGCOLL-5758-rtl fix offset --- src/components/musette/musette.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/musette/musette.scss b/src/components/musette/musette.scss index a3c48bab..3759bfd7 100644 --- a/src/components/musette/musette.scss +++ b/src/components/musette/musette.scss @@ -16,11 +16,11 @@ $button-height: 42px; } .la-musette--offset > :first-child { - margin-left: 7.5vw; + margin-left: $spacing-component-margin; } .la-musette--offset > :last-child { - margin-right: 7.5vw; + margin-right: $spacing-component-margin; } .la-musette--no-scrollbar { From 6c4feb22df2498be6be34bab4b6aa25b9eaaa09b Mon Sep 17 00:00:00 2001 From: davidseguin Date: Wed, 28 Sep 2022 11:22:32 -0400 Subject: [PATCH 3/5] update story --- src/components/musette/musette.stories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/musette/musette.stories.js b/src/components/musette/musette.stories.js index 713ed5cf..e6e36f1d 100644 --- a/src/components/musette/musette.stories.js +++ b/src/components/musette/musette.stories.js @@ -38,7 +38,7 @@ const slideTemplate = (args) => { const Musette = () => { useEffect(() => { initialize(); }); return html` -
+
${titles.map((title, index) => slideTemplate({ title: title, imageURL: images[index % 3].srcSet.fallback })).join("")}
`; }; From d294e893c2b892e2d6c36691e88167888432b2e4 Mon Sep 17 00:00:00 2001 From: Stephen Marsh Date: Wed, 28 Sep 2022 13:25:27 -0400 Subject: [PATCH 4/5] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ac31ece0..c0071c01 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ https://about.gitlab.com/topics/version-control/what-is-innersource/) project. Our component explorer, powered by [Storybook](https://storybook.js.org/docs/basics/introduction/), lives on Chromatic at: -## 🏛️ [main--5ef272f9ab690c0022ef30ab.chromatic.com](https://main--5ef272f9ab690c0022ef30ab.chromatic.com) 📙 +## 🏛️ [marble.metmuseum.org](https://marble.metmuseum.org) 📙 # Design Documentation and Homepage From 5a91d1a1cbe705a30f8fc7df571f7079dadedecb Mon Sep 17 00:00:00 2001 From: Stephen Marsh Date: Wed, 28 Sep 2022 13:26:13 -0400 Subject: [PATCH 5/5] Update README.md --- README.md | 7 ------- 1 file changed, 7 deletions(-) diff --git a/README.md b/README.md index c0071c01..4d25b49c 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,6 @@ - [What is Marble?](#What-is-Marble) - [Component Explorer](#Component-Explorer) -- [Design Documentation and Homepage](#Design-Documentation-and-Homepage) - [Using Marble In Your Project](#Using-Marble-In-Your-Project) - [How To Contribute To Marble](#Contributing-To-Marble) - [Marble Development As A Local Package](#Marble-Development-As-A-Local-Package) @@ -31,12 +30,6 @@ Our component explorer, powered by [Storybook](https://storybook.js.org/docs/bas ## 🏛️ [marble.metmuseum.org](https://marble.metmuseum.org) 📙 -# Design Documentation and Homepage - -Marble's design docs and homepage are at: - -🎨 https://marble.metmuseum.org/ 🏡 - # Using Marble In Your Project ## Installing Marble