Silently cast numeric property keys to string

This counteracts `json_encode` silently casting numeric strings to numbers.

Author: charjr

src/ValueObject/Valid/V30/Keywords.php

@@ -423,16 +423,10 @@ private function validateProperties(?array $properties): array
 
         $result = [];
         foreach ($properties as $key => $subSchema) {
-            if (!is_string($key)) {
-                throw InvalidOpenAPI::mustHaveStringKeys(
-                    $this->getIdentifier(),
-                    'properties',
-                );
-            }
-
-            $result[$key] = new Schema(
+            // json_decode casts numeric string keys to numbers
+            $result[(string) $key] = new Schema(
                 $this->getIdentifier()->append("properties($key)"),
-                $subSchema
+                $subSchema,
             );
         }
 

src/ValueObject/Valid/V31/Keywords.php

@@ -445,16 +445,10 @@ private function validateProperties(?array $properties): array
 
         $result = [];
         foreach ($properties as $key => $subSchema) {
-            if (!is_string($key)) {
-                throw InvalidOpenAPI::mustHaveStringKeys(
-                    $this->getIdentifier(),
-                    'properties',
-                );
-            }
-
-            $result[$key] = new Schema(
+            // json_decode casts numeric string keys to numbers
+            $result[(string) $key] = new Schema(
                 $this->getIdentifier()->append("properties($key)"),
-                $subSchema
+                $subSchema,
             );
         }
 

tests/MembraneReaderTest.php

@@ -14,7 +14,6 @@
 use Membrane\OpenAPIReader\Factory\V30\FromCebe;
 use Membrane\OpenAPIReader\MembraneReader;
 use Membrane\OpenAPIReader\Tests\Fixtures\Helper\OpenAPIProvider;
-use Membrane\OpenAPIReader\Tests\Fixtures\Helper\PartialHelper;
 use Membrane\OpenAPIReader\ValueObject\Partial;
 use Membrane\OpenAPIReader\ValueObject\Valid;
 use Membrane\OpenAPIReader\ValueObject\Valid\Enum\Method;
@@ -373,6 +372,62 @@ public function itReadsRealExamples(
         self::assertEquals($expected, $actual);
     }
 
+    #[Test]
+    public function itReadsStringNumericKeysAsStrings(): void
+    {
+        $sut = new MembraneReader([
+            OpenAPIVersion::Version_3_0,
+            OpenAPIVersion::Version_3_1,
+        ]);
+
+        $api = json_encode([
+            'openapi' => '3.0.3',
+            'info' => [
+                'title' => 'Numeric Property Keys',
+                'version' => '1.0.0',
+            ],
+            'paths' => ['/foo' => ['parameters' => [[
+                'name' => 'object-with-numeric-keys',
+                'in' => 'query',
+                'schema' => [
+                    'type' => 'object',
+                    'properties' => [
+                        '1' => ['type' => 'string'],
+                    ]
+                ]
+            ]]]]
+        ]);
+
+        $expected = OpenAPI::fromPartial(new Partial\OpenAPI(
+            openAPI: '3.0.3',
+            title: 'Numeric Property Keys',
+            version: '1.0.0',
+            paths: [
+                new Partial\PathItem(
+                    path: '/foo',
+                    parameters: [
+                        new Partial\Parameter(
+                            name: 'object-with-numeric-keys',
+                            in: 'query',
+                            schema: new Partial\Schema(
+                                type: 'object',
+                                properties: [
+                                    '1' => new Partial\Schema(type: 'string'),
+                                ],
+                            )
+                        ),
+                    ]
+                )
+            ]
+        ));
+
+        $actual = $sut->readFromString($api, FileFormat::Json);
+
+
+
+        self::assertEquals($expected, $actual);
+    }
+
     public static function provideInvalidFormatting(): Generator
     {
         yield 'Empty string to be interpreted as json' => ['', FileFormat::Json];