Skip to content

Commit 3a8f2b5

Browse files
committed
fix: incosistencies between skill and existing patterns
Signed-off-by: Mouad BANI <mouad-mb@outlook.com>
1 parent 0a94ac4 commit 3a8f2b5

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

  • .claude/skills/scaffold-snowflake-connector

.claude/skills/scaffold-snowflake-connector/SKILL.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ For each activity type the user provides, suggest the following **one at a time*
295295
| Enum key | SCREAMING_SNAKE_CASE version of the name (e.g., `ENROLLED_CERTIFICATION`) |
296296
| String value | The name the user provided (kebab-case) |
297297
| Label | Human-readable (e.g., `Enrolled in certification`) |
298-
| Description | One sentence describing the event (look at similar types in `backend/src/c/migrations/` for style) |
298+
| Description | One sentence describing the event (follow the style in `backend/src/database/migrations/V1771497876__addCventActivityTypes.sql` and `V1772556158__addTncActivityTypes.sql`) |
299299
| `isCodeContribution` | `false` unless it involves code (check existing platforms — almost always false for non-GitHub sources) |
300300
| `isCollaboration` | `false` unless it is a collaborative activity |
301301
@@ -412,9 +412,9 @@ Add `OrganizationAttributeSource.{PLATFORM},` to the `ORG_DB_ATTRIBUTE_SOURCE_PR
412412

413413
**Touch point 5 — Flyway migration** (new file)
414414

415-
File: `backend/src/database/migrations/V{Date.now()}__add{Platform}ActivityTypes.sql`
415+
File: `backend/src/database/migrations/V{epoch_seconds}__add{Platform}ActivityTypes.sql`
416416

417-
Template (use epoch timestamp for `V` prefix — run `date +%s%3N` in terminal):
417+
Template (use a 10-digit second-epoch for the `V` prefix, matching existing migrations — run `date +%s` in terminal):
418418

419419
```sql
420420
INSERT INTO "activityTypes" ("activityType", platform, "isCodeContribution", "isCollaboration", description, "label") VALUES
@@ -474,7 +474,7 @@ These are AI-generated from the confirmed column mappings. Apply all rules stric
474474
File: `services/apps/snowflake_connectors/src/integrations/{platform}/{source}/buildSourceQuery.ts`
475475

476476
**Rules (enforced — do not deviate):**
477-
- Use explicit column names only. Never use `table.*`
477+
- Use explicit column names only. Do not use `table.*` or `table.* EXCLUDE (...)` in new implementations — existing sources (TNC, CVENT) use these patterns but new sources should list columns explicitly to avoid parquet encoding/decoding issues
478478
- If any TIMESTAMP_TZ columns exist in the schema, exclude and re-cast them as TIMESTAMP_NTZ (see CVENT pattern)
479479
- Follow the CTE structure:
480480
1. `org_accounts` CTE (if org data present)
@@ -572,7 +572,7 @@ Fix any errors or warnings and re-run `pnpm run lint` until it reports no compla
572572
Before declaring the implementation complete, verify every item:
573573

574574
- [ ] All applicable files from the File Inventory written to disk
575-
- [ ] No `table.*` anywhere in any generated query
575+
- [ ] No `table.*` or `table.* EXCLUDE (...)` in any generated query
576576
- [ ] No broad `else` in any transformer
577577
- [ ] All string comparisons are case-insensitive (`.toLowerCase()` on both sides of comparison)
578578
- [ ] `sourceId` confirmed unique in test data

0 commit comments

Comments
 (0)