We have a guard clause in the transmission class that prevents a signal from being transmitted if it's missing critical information
|
def transmit |
|
return self unless attributes_required_to_transmit_present? |
Several times now I've been confused when debugging why a signal didn't send, just to realize again that it's silently not being sent because it wasn't valid.
I think we could help users out (and future us lol) by making it more apparent when you are in this situation. If this is happening, you intended for a signal to be sent and have defined it and there are apps that are listening for this signal. I think that it would qualify as an exceptional situation because of that and not a normal failure state, especially since it means there was probably a mistake in how the signal was defined or call since it's missing critical information.
Let's look into raising a demux specific exception when this guard clause is activated.
We have a guard clause in the transmission class that prevents a signal from being transmitted if it's missing critical information
demux/app/models/demux/transmission.rb
Lines 36 to 37 in a25d874
Several times now I've been confused when debugging why a signal didn't send, just to realize again that it's silently not being sent because it wasn't valid.
I think we could help users out (and future us lol) by making it more apparent when you are in this situation. If this is happening, you intended for a signal to be sent and have defined it and there are apps that are listening for this signal. I think that it would qualify as an exceptional situation because of that and not a normal failure state, especially since it means there was probably a mistake in how the signal was defined or call since it's missing critical information.
Let's look into raising a demux specific exception when this guard clause is activated.