refactor(studio): the stored volume reader lives in its own file, under the helpers' size limit

Author: miguel-heygen

packages/studio/src/player/lib/automationStoreSync.ts

@@ -25,11 +25,11 @@ import {
 import { usePlayerStore, type TimelineElement } from "../store/playerStore";
 import { groupInfoFor } from "./timelineGroupInfo";
 import {
-  elementVolume,
   getTimelineElementIdentity,
-  parseStoredVolume,
   previewElementFinder,
+  resolveMediaElement,
 } from "./timelineElementHelpers";
+import { elementVolume, parseStoredVolume } from "./storedVolume";
 
 /**
  * Re-read every element's automation, FX-chain, fade and volume attributes from the preview
@@ -60,7 +60,7 @@ function syncedFields(doc: Document, element: TimelineElement, node: Element) {
     fxChain: node.getAttribute(HF_AUDIO_FX_ATTR) ?? undefined,
     fadeIn: storedFade(fades.fadeIn),
     fadeOut: storedFade(fades.fadeOut),
-    volume: elementVolume(node),
+    volume: elementVolume(node, resolveMediaElement(node) ?? node),
     audioGroupAutomation: group?.automation,
     audioGroupFxChain: group?.fxChain,
   };

packages/studio/src/player/lib/storedVolume.ts

@@ -0,0 +1,8 @@
+export function parseStoredVolume(text: string | null): number | undefined {
+  const volume = Number.parseFloat(text ?? "");
+  return Number.isFinite(volume) ? volume : undefined;
+}
+
+/** Discovery's reading: the element's own `data-volume`, else its media's. */
+export const elementVolume = (el: Element, media: Element) =>
+  parseStoredVolume(el.getAttribute("data-volume") ?? media.getAttribute("data-volume"));

packages/studio/src/player/lib/timelineElementHelpers.ts

@@ -13,6 +13,7 @@ import { isFinitePositive } from "./playbackAdapter";
 import { getSourceScopedSelectorIndex } from "../../utils/sourceScopedSelectorIndex";
 import { HF_AUDIO_GROUP_TAG } from "@hyperframes/core/audio-groups";
 import { readElementFades } from "@hyperframes/core/audio-fade";
+import { elementVolume } from "./storedVolume";
 import {
   type AttrReader,
   clampPlaybackRate,
@@ -213,11 +214,6 @@ function setOptional<K extends keyof TimelineElement>(
   else entry[key] = value;
 }
 
-export function parseStoredVolume(text: string | null): number | undefined {
-  const volume = Number.parseFloat(text ?? "");
-  return Number.isFinite(volume) ? volume : undefined;
-}
-
 /** The compiler's rule (timingCompiler): explicit data-has-audio wins; otherwise an unmuted <video> is audible. */
 export function isVideoAudible(opts: {
   tag: string;
@@ -238,12 +234,6 @@ export function isAudibleVideoNode(el: Element): boolean {
   });
 }
 
-function readVolume(el: Element, media: Element): number | undefined {
-  return parseStoredVolume(el.getAttribute("data-volume") ?? media.getAttribute("data-volume"));
-}
-
-export const elementVolume = (el: Element) => readVolume(el, resolveMediaElement(el) ?? el);
-
 /** What the mixer gets: the compiler's `data-has-audio` rule, muted and volume. */
 function applyAudioMetadataFromElement(entry: TimelineElement, el: Element): void {
   const media = resolveMediaElement(el) ?? el;
@@ -255,7 +245,7 @@ function applyAudioMetadataFromElement(entry: TimelineElement, el: Element): voi
   });
   setOptional(entry, "hasAudio", sound ? true : undefined);
   setOptional(entry, "muted", muted ? true : undefined);
-  setOptional(entry, "volume", readVolume(el, media));
+  setOptional(entry, "volume", elementVolume(el, media));
 }
 
 function applyFadeMetadataFromElement(entry: TimelineElement, el: Element): void {