Adding dry_run for migrate_datasets for getting the MAQL chunks. Migrate does not crash when chunks are nil. The title is based on identifier now.

Author: Tomas Svarovsky

lib/gooddata/models/from_wire.rb

@@ -90,7 +90,7 @@ def self.parse_date_dimensions(stuff)
           d[:type] = :date_dimension
           # d[:urn] = :date_dimension
           d[:name] = stuff['dateDimension']['name']
-          d[:title] = stuff['dateDimension']['title'] if stuff['dateDimension']['title'] != stuff['dateDimension']['title'].titleize
+          d[:title] = stuff['dateDimension']['title'] if stuff['dateDimension']['title'] != d[:name].titleize
         end
       end
 

lib/gooddata/models/model.rb

@@ -29,7 +29,7 @@ def title(item)
         item[:title] || item[:name].titleize
       end
 
-      def identifier_for(dataset, column = nil, column2 = nil)
+      def identifier_for(dataset, column = nil, column2 = nil) # rubocop:disable UnusedMethodArgument
         return "dataset.#{dataset[:name]}" if column.nil?
         column = DatasetBlueprint.find_column_by_name(dataset, column) if column.is_a?(String)
         case column[:type].to_sym
@@ -46,11 +46,15 @@ def identifier_for(dataset, column = nil, column2 = nil)
         when :primary_label
           "label.#{dataset[:name]}.#{column[:name]}"
         when :label
-          "label.#{dataset[:name]}.#{column2[:name]}.#{column[:name]}"
+          "label.#{dataset[:name]}.#{column[:reference]}.#{column[:name]}"
         when :date_ref
           "#{dataset[:name]}.date.mdyy"
         when :dataset
           "dataset.#{dataset[:name]}"
+        when :date
+          'DATE'
+        when :reference
+          'REF'
         else
           fail "Unknown type #{column[:type].to_sym}"
         end

lib/gooddata/models/project_creator.rb

@@ -9,7 +9,8 @@ module GoodData
   module Model
     class ProjectCreator
       class << self
-        def migrate(opts = { client: GoodData.connection, project: GoodData.project })
+        def migrate(opts = {})
+          opts = { client: GoodData.connection, project: GoodData.project }.merge(opts)
           client = opts[:client]
           fail ArgumentError, 'No :client specified' if client.nil?
 
@@ -25,27 +26,21 @@ def migrate(opts = { client: GoodData.connection, project: GoodData.project })
 
           begin
             GoodData.with_project(project, opts) do |p|
-              # migrate_date_dimensions(p, spec[:date_dimensions] || [])
-              migrate_datasets(spec, :project => p, :client => client)
+              migrate_datasets(spec, opts.merge(project: p, client: client))
               load(p, spec)
               migrate_metrics(p, spec[:metrics] || [])
               migrate_reports(p, spec[:reports] || [])
               migrate_dashboards(p, spec[:dashboards] || [])
-              migrate_users(p, spec[:users] || [])
               execute_tests(p, spec[:assert_tests] || [])
               p
             end
           end
         end
 
-        def migrate_date_dimensions(project, spec)
-          spec.each do |dd|
-            Model.add_schema(DateDimension.new(dd), project)
-          end
-        end
-
-        def migrate_datasets(spec, opts = { :client => GoodData.connection })
+        def migrate_datasets(spec, opts = {})
+          opts = { client: GoodData.connection }.merge(opts)
           client = opts[:client]
+          dry_run = opts[:dry_run]
           fail ArgumentError, 'No :client specified' if client.nil?
 
           p = opts[:project]
@@ -63,29 +58,29 @@ def migrate_datasets(spec, opts = { :client => GoodData.connection })
           link = result['asyncTask']['link']['poll']
           response = client.get(link, :process => false)
 
-          # pp response
           while response.code != 200
             sleep 1
             GoodData::Rest::Client.retryable(:tries => 3) do
               sleep 1
               response = client.get(link, :process => false)
-              # pp response
             end
           end
 
           response = client.get(link)
 
           chunks = pick_correct_chunks(response['projectModelDiff']['updateScripts'])
-          chunks['updateScript']['maqlDdlChunks'].each do |chunk|
-            result = project.execute_maql(chunk)
-            fail 'Creating dataset failed' if result['wTaskStatus']['status'] == 'ERROR'
-          end
-
-          bp.datasets.zip(GoodData::Model::ToManifest.to_manifest(bp.to_hash)).each do |ds|
-            dataset = ds[0]
-            manifest = ds[1]
-            GoodData::ProjectMetadata["manifest_#{dataset.name}", :client => client, :project => project] = manifest.to_json
+          if !chunks.nil? && !dry_run
+            chunks['updateScript']['maqlDdlChunks'].each do |chunk|
+              result = project.execute_maql(chunk)
+              fail 'Creating dataset failed' if result['wTaskStatus']['status'] == 'ERROR'
+            end
+            bp.datasets.zip(GoodData::Model::ToManifest.to_manifest(bp.to_hash)).each do |ds|
+              dataset = ds[0]
+              manifest = ds[1]
+              GoodData::ProjectMetadata["manifest_#{dataset.name}", :client => client, :project => project] = manifest.to_json
+            end
           end
+          chunks
         end
 
         def migrate_reports(project, spec)
@@ -106,13 +101,6 @@ def migrate_metrics(project, spec)
           end
         end
 
-        def migrate_users(_project, spec)
-          spec.each do |user|
-            puts "Would migrate user #{user}"
-            # project.add_user(user)
-          end
-        end
-
         def load(project, spec)
           if spec.key?(:uploads) # rubocop:disable Style/GuardClause
             spec[:uploads].each do |load|

spec/integration/full_project_spec.rb

@@ -20,6 +20,32 @@
     }.to raise_error(GoodData::ValidationError)
   end
 
+  it "should do nothing if the project is updated with the same blueprint" do
+    results = GoodData::Model::ProjectCreator.migrate_datasets(@spec, project: @project, client: @client, dry_run: true)
+    expect(results).to be_nil
+  end
+
+  it 'should try to rename a dataset back' do
+    dataset = @project.datasets('dataset.repos')
+    dataset.title = "Some title"
+    dataset.save
+
+    # Now the update of project using the original blueprint should offer update of the title. Nothing else.
+    results = GoodData::Model::ProjectCreator.migrate_datasets(@spec, project: @project, client: @client, dry_run: true)
+    expect(results['updateScript']['maqlDdl']).to eq "ALTER DATASET {dataset.repos} VISUAL(TITLE \"Repos\", DESCRIPTION \"\");\n"
+
+    # Update using a freshly gained blueprint should offer no changes.
+    new_blueprint = @project.blueprint
+    results = GoodData::Model::ProjectCreator.migrate_datasets(new_blueprint, project: @project, client: @client, dry_run: true)
+    expect(results).to be_nil
+
+    # When we change the model using the original blueprint. Basically change the title back.
+    results = GoodData::Model::ProjectCreator.migrate_datasets(@spec, project: @project, client: @client)
+    # It should offer no changes using the original blueprint
+    results = GoodData::Model::ProjectCreator.migrate_datasets(@spec, project: @project, client: @client, dry_run: true)
+    expect(results).to be_nil
+  end
+
   it "should contain datasets" do
     @project.blueprint.tap do |bp|
       expect(bp.datasets.count).to eq 3