Added connection to the several places to allow function with global dialect. Removing test that expects to fail.

Author: Tomas Svarovsky

lib/gooddata/mixins/md_object_query.rb

@@ -8,7 +8,7 @@ module MdObjectQuery
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         fail NotImplementedError, 'Method should be implemented in subclass. Currently there is no way how to get all metadata objects on API.'
       end
 

lib/gooddata/models/metadata/attribute.rb

@@ -20,7 +20,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('attributes', Attribute, options)
       end
 

lib/gooddata/models/metadata/dashboard.rb

@@ -17,7 +17,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('projectdashboards', Dashboard, options)
       end
 

lib/gooddata/models/metadata/fact.rb

@@ -21,7 +21,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('facts', Fact, options)
       end
     end

lib/gooddata/models/metadata/label.rb

@@ -68,10 +68,6 @@ def values(options = {})
     # Gives an attribute of current label
     # @return [GoodData::Attibute]
     def attribute
-      opts = {
-        :client => client,
-        :project => project
-      }
       project.attributes(content['formOf'])
     end
 

lib/gooddata/models/metadata/metric.rb

@@ -23,7 +23,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('metrics', Metric, options)
       end
 
@@ -215,14 +215,16 @@ def pretty_expression
       }
 
       temp = expression.dup
-      expression.scan(PARSE_MAQL_OBJECT_REGEXP).pmap do |uri|
+      pairs = expression.scan(PARSE_MAQL_OBJECT_REGEXP).pmap do |uri|
         uri = uri.first
         if uri =~ /elements/
           [uri, Attribute.find_element_value(uri, opts)]
         else
           [uri, GoodData::MdObject[uri, opts].title]
         end
-      end.each do |el|
+      end
+
+      pairs.each do |el|
         uri = el[0]
         obj = el[1]
         temp.sub!(uri, obj)

lib/gooddata/models/metadata/report.rb

@@ -13,7 +13,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('reports', Report, options)
       end
 
@@ -26,9 +26,9 @@ def create(options = { :client => GoodData.connection, :project => GoodData.proj
 
         project = GoodData::Project[p, options]
         fail ArgumentError, 'Wrong :project specified' if project.nil?
-        
+
         title = options[:title]
-        fail "Report needs a title specified" unless title
+        fail 'Report needs a title specified' unless title
         summary = options[:summary] || ''
         rd = options[:rd] || ReportDefinition.create(options)
         rd.save
@@ -55,7 +55,7 @@ def create(options = { :client => GoodData.connection, :project => GoodData.proj
 
     # Add a report definition to a report. This will show on a UI as a new version.
     #
-    # @param report_definition [GoodData::ReportDefinition | String] Report definition to add. Either it can be a URI of a report definition or an actual report definition object. 
+    # @param report_definition [GoodData::ReportDefinition | String] Report definition to add. Either it can be a URI of a report definition or an actual report definition object.
     # @return [GoodData::Report] Return self
     def add_definition(report_definition)
       rep_def = project.report_definitions(report_definition)
@@ -68,7 +68,7 @@ def results
     end
 
     def definitions
-      content['definitions'].pmap {|uri| project.report_definitions(uri)}
+      content['definitions'].pmap { |uri| project.report_definitions(uri) }
     end
 
     def definition_uris
@@ -138,7 +138,7 @@ def replace(what, for_what)
       new_defs = definitions.map do |rep_def|
         rep_def.replace(what, for_what)
       end
-      new_defs.pmap &:save
+      new_defs.pmap(&:save)
     end
   end
 end

lib/gooddata/models/metadata/report_definition.rb

@@ -16,7 +16,7 @@ class << self
       # @param options [Hash] the options hash
       # @option options [Boolean] :full if passed true the subclass can decide to pull in full objects. This is desirable from the usability POV but unfortunately has negative impact on performance so it is not the default
       # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
-      def all(options = {})
+      def all(options = { :client => GoodData.connection, :project => GoodData.project })
         query('reportdefinition', ReportDefinition, options)
       end
 
@@ -231,11 +231,11 @@ def attribute_parts
     end
 
     def attributes
-      labels.map {|label| label.attribute}
+      labels.map { |label| label.attribute }
     end
 
     def labels
-      attribute_parts.map {|part| project.labels(part['attribute']['uri'])}
+      attribute_parts.map { |part| project.labels(part['attribute']['uri']) }
     end
 
     def metric_parts
@@ -264,7 +264,7 @@ def execute(opts = { :client => GoodData.connection, :project => GoodData.projec
     end
 
     def filters
-      content['filters'].map {|f| f['expression']}
+      content['filters'].map { |f| f['expression'] }
     end
 
     # Replace certain object in report definition. Returns new definition which is not saved.
@@ -274,12 +274,12 @@ def filters
     # @return [Array<GoodData::MdObject> | Array<Hash>] Return the appropriate metadata objects or their representation
     def replace(what, for_what = nil)
       pairs = if what.is_a?(Hash)
-        whats = what.keys
-        to_whats = what.values
-        whats.zip(to_whats)
-      else
-        [[what, for_what]]
-      end
+                whats = what.keys
+                to_whats = what.values
+                whats.zip(to_whats)
+              else
+                [[what, for_what]]
+              end
 
       pairs.each do |pair|
         what = pair[0]
@@ -333,9 +333,9 @@ def replace(what, for_what = nil)
         content['grid']['sort']['columns'] = sort.map do |item|
           if item.is_a?(Hash)
             item.deep_dup.tap do |i|
-              next if not i.key?('metricSort')
-              next if not i['metricSort'].key?('locators')
-              next if not i['metricSort']['locators'][0].key?('attributeLocator2')
+              next unless i.key?('metricSort')
+              next unless i['metricSort'].key?('locators')
+              next unless i['metricSort']['locators'][0].key?('attributeLocator2')
               i['metricSort']['locators'][0]['attributeLocator2']['uri'].gsub!(uri_what, uri_for_what)
               i['metricSort']['locators'][0]['attributeLocator2']['element'].gsub!(uri_what, uri_for_what)
             end
@@ -358,7 +358,7 @@ def replace(what, for_what = nil)
           end
         end
 
-        content['filters'] = filters.map { |filter_expression| { 'expression' => filter_expression.gsub(uri_what, uri_for_what) }}
+        content['filters'] = filters.map { |filter_expression| { 'expression' => filter_expression.gsub(uri_what, uri_for_what) } }
       end
       self
     end

lib/gooddata/rest/client.rb

@@ -85,7 +85,7 @@ def connect(username, password, opts = {})
           end
 
           # HACK: This line assigns class instance # if not done yet
-          # @@instance = client # rubocop:disable ClassVars
+          @@instance = client # rubocop:disable ClassVars
           client
         end
 

lib/gooddata/rest/connection.rb

@@ -54,7 +54,7 @@ def initialize(opts)
       def connect(username, password, options = {})
         # Reset old cookies first
         if options[:sst_token]
-          merge_cookies!({ 'GDCAuthSST' => options[:sst_token] })
+          merge_cookies!('GDCAuthSST' => options[:sst_token])
           @user = get(get('/gdc/app/account/bootstrap')['bootstrapResource']['accountSetting']['links']['self'])
           @auth = {}
           refresh_token :dont_reauth => true