Skip to content

Commit fd8e2b3

Browse files
authored
Merge pull request #746 from no23reason/dho-cq-652-native-nat
refactor: adapt to the change of NATIVE -> NAT on backend
2 parents 404b214 + 92038ef commit fd8e2b3

1 file changed

Lines changed: 1 addition & 8 deletions

File tree

gooddata-sdk/gooddata_sdk/compute/model/execution.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -175,20 +175,13 @@ def _create_totals(self) -> Optional[list[models.Total]]:
175175
models.Total(
176176
local_identifier=total.local_id,
177177
metric=total.metric_local_id,
178-
function=ExecutionDefinition._convert_total_aggregation(total.aggregation),
178+
function=total.aggregation.upper(),
179179
total_dimensions=total_dims,
180180
)
181181
)
182182

183183
return totals
184184

185-
@staticmethod
186-
def _convert_total_aggregation(aggregation: str) -> str:
187-
# native total is represented as NAT in visualization objects, but needs to be NATIVE in execution
188-
if aggregation.upper() == "NAT":
189-
return "NATIVE"
190-
return aggregation.upper()
191-
192185
def _create_result_spec(self) -> models.ResultSpec:
193186
dimensions = self._create_dimensions()
194187
totals = self._create_totals()

0 commit comments

Comments
 (0)