Skip to content

Commit d51ea62

Browse files
committed
feat: utilize almost majority of UP rules
JIRA: TRIVIAL risk: low
1 parent 73e61db commit d51ea62

49 files changed

Lines changed: 84 additions & 86 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

gooddata-dbt/tests/test_tables.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414

1515
def _read_json(path: Union[str, Path]) -> dict:
16-
with open(path, "r") as f:
16+
with open(path) as f:
1717
return json.load(f)
1818

1919

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
# (C) 2021 GoodData Corporation
2-
try:
3-
from importlib import metadata
4-
except ImportError:
5-
import importlib_metadata as metadata # type: ignore # mypy issue #1153
2+
from importlib import metadata
63

74
__version__: str = metadata.version("gooddata-fdw")

gooddata-fdw/gooddata_fdw/executor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# (C) 2022 GoodData Corporation
22
from __future__ import annotations
33

4-
from typing import Any, Generator, NamedTuple, Optional
4+
from collections.abc import Generator
5+
from typing import Any, NamedTuple, Optional
56

67
from gooddata_sdk import GoodDataSdk
78

gooddata-fdw/gooddata_fdw/fdw.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
class GoodDataForeignDataWrapper(ForeignDataWrapper):
2121
def __init__(self, options: dict[str, str], columns: dict[str, ColumnDefinition]) -> None:
22-
super(GoodDataForeignDataWrapper, self).__init__(options, columns)
22+
super().__init__(options, columns)
2323
_log_debug(f"initializing (options={options}, columns={columns})")
2424

2525
# Table options contain also foreign server options

gooddata-fdw/gooddata_fdw/result_reader.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
# (C) 2022 GoodData Corporation
22
from __future__ import annotations
33

4-
from typing import Any, Generator
4+
from collections.abc import Generator
5+
from typing import Any
56

67
from gooddata_sdk import ExecutionTable
78
from gooddata_sdk.type_converter import DBTypeConverterStore

gooddata-fdw/tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def pytest_addoption(parser):
2020
@pytest.fixture(scope="session")
2121
def test_config(request):
2222
config_path = Path(request.config.getoption("--gd-test-config"))
23-
with open(config_path, "rt") as f:
23+
with open(config_path) as f:
2424
config = yaml.safe_load(f)
2525

2626
return config

gooddata-flight-server/gooddata_flight_server/_version.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
# (C) 2024 GoodData Corporation
2-
try:
3-
from importlib import metadata
4-
except ImportError:
5-
import importlib_metadata as metadata # type: ignore # mypy issue #1153
2+
from importlib import metadata
63

74
try:
85
__version__ = metadata.version("gooddata-flight-server")

gooddata-flight-server/gooddata_flight_server/flexfun/flex_fun_registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# (C) 2024 GoodData Corporation
22
import importlib
3-
from typing import Iterable
3+
from collections.abc import Iterable
44

55
import structlog
66

gooddata-flight-server/gooddata_flight_server/flexfun/flex_fun_task.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# (C) 2024 GoodData Corporation
2-
from typing import Iterable, Optional, Union
2+
from collections.abc import Iterable
3+
from typing import Optional, Union
34

45
import pyarrow
56
import structlog

gooddata-flight-server/gooddata_flight_server/flexfun/flight_methods.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# (C) 2024 GoodData Corporation
2-
from typing import Generator, Optional
2+
from collections.abc import Generator
3+
from typing import Optional
34

45
import orjson
56
import pyarrow.flight

0 commit comments

Comments
 (0)