feat: ability to patch existing IdP

Fixture updates as well as `oauthIssuerId` is no longer an attripute of IdP

JIRA: TRIVIAL
risk: low

Author: chrisbonilla95

gooddata-sdk/gooddata_sdk/catalog/organization/entity_model/identity_provider.py

@@ -7,6 +7,9 @@
 from gooddata_api_client.model.json_api_identity_provider_in import JsonApiIdentityProviderIn
 from gooddata_api_client.model.json_api_identity_provider_in_attributes import JsonApiIdentityProviderInAttributes
 from gooddata_api_client.model.json_api_identity_provider_in_document import JsonApiIdentityProviderInDocument
+from gooddata_api_client.model.json_api_identity_provider_patch import JsonApiIdentityProviderPatch
+from gooddata_api_client.model.json_api_identity_provider_patch_attributes import JsonApiIdentityProviderPatchAttributes
+from gooddata_api_client.model.json_api_identity_provider_patch_document import JsonApiIdentityProviderPatchDocument
 
 from gooddata_sdk.catalog.base import Base
 from gooddata_sdk.utils import safeget
@@ -38,7 +41,6 @@ def init(
         identifiers: Optional[list[str]] = None,
         oauth_client_id: Optional[str] = None,
         oauth_client_secret: Optional[str] = None,
-        oauth_issuer_id: Optional[str] = None,
         oauth_issuer_location: Optional[str] = None,
         saml_metadata: Optional[str] = None,
     ) -> CatalogIdentityProvider:
@@ -49,7 +51,6 @@ def init(
                 identifiers=identifiers,
                 oauth_client_id=oauth_client_id,
                 oauth_client_secret=oauth_client_secret,
-                oauth_issuer_id=oauth_issuer_id,
                 oauth_issuer_location=oauth_issuer_location,
                 saml_metadata=saml_metadata,
             ),
@@ -63,7 +64,6 @@ def from_api(cls, entity: dict[str, Any]) -> CatalogIdentityProvider:
             identifiers=safeget(ea, ["identifiers"]),
             oauth_client_id=safeget(ea, ["oauth_client_id"]),
             oauth_client_secret=safeget(ea, ["oauth_client_secret"]),
-            oauth_issuer_id=safeget(ea, ["oauth_issuer_id"]),
             oauth_issuer_location=safeget(ea, ["oauth_issuer_location"]),
             saml_metadata=safeget(ea, ["saml_metadata"]),
         )
@@ -72,14 +72,21 @@ def from_api(cls, entity: dict[str, Any]) -> CatalogIdentityProvider:
             attributes=attr,
         )
 
+    @classmethod
+    def to_api_patch(cls, identity_provider_id: str, attributes: dict) -> JsonApiIdentityProviderPatchDocument:
+        return JsonApiIdentityProviderPatchDocument(
+            data=JsonApiIdentityProviderPatch(
+                id=identity_provider_id, attributes=JsonApiIdentityProviderPatchAttributes(**attributes)
+            )
+        )
+
 
 @attr.s(auto_attribs=True, kw_only=True)
 class CatalogIdentityProviderAttributes(Base):
     custom_claim_mapping: Optional[dict[str, str]] = None
     identifiers: Optional[list[str]] = None
     oauth_client_id: Optional[str] = None
     oauth_client_secret: Optional[str] = None
-    oauth_issuer_id: Optional[str] = None
     oauth_issuer_location: Optional[str] = None
     saml_metadata: Optional[str] = None
 

gooddata-sdk/gooddata_sdk/catalog/organization/layout/identity_provider.py

@@ -15,7 +15,6 @@ class CatalogDeclarativeIdentityProvider(Base):
     identifiers: Optional[list[str]] = None
     oauth_client_id: Optional[str] = None
     oauth_client_secret: Optional[str] = None
-    oauth_issuer_id: Optional[str] = None
     oauth_issuer_location: Optional[str] = None
     saml_metadata: Optional[str] = None
 

gooddata-sdk/gooddata_sdk/catalog/organization/service.py

@@ -407,6 +407,23 @@ def update_identity_provider(self, identity_provider: CatalogIdentityProvider) -
                 f"Can not update {identity_provider.id} identity provider. This identity provider does not exist."
             )
 
+    def patch_identity_provider_attributes(self, identity_provider_id: str, attributes: dict) -> None:
+        """Applies changes to the specified identity provider.
+
+        Args:
+            identity_provider_id (str):
+                Identity Provider identification string. e.g. "auth0"
+            attributes (dict):
+                A dictionary containing attributes of the identity provider to be changed.
+
+        Returns:
+            None
+        """
+
+        self._entities_api.patch_entity_identity_providers(
+            identity_provider_id, CatalogIdentityProvider.to_api_patch(identity_provider_id, attributes)
+        )
+
     # Layout APIs
 
     def get_declarative_notification_channels(self) -> list[CatalogDeclarativeNotificationChannel]: