[Governance] Separate flag records by content type to prevent ID collisions

[3m1n3nc3]

Description

Flag records and flag counts are keyed only by target_id, while giveaways and help requests have separate counters in the same numeric range. This allows flagging or suspension behavior to collide across content types that share the same ID.

User Story

As a Protocol User,
I want to flag the exact content item I intended,
so that moderation actions do not accidentally affect a giveaway and help request that happen to share the same numeric ID.

Requirements and Context

• Files / refs: contracts/geev-core/src/governance.rs, contracts/geev-core/src/types.rs, contracts/geev-core/src/test.rs
• Replace FlagRecord(u64, Address) and FlagCount(u64) with content-type-aware keys
• Update flag_content, get_flag_count, has_flagged, and auto_suspend to resolve the correct content type explicitly
• Add regression tests covering same-ID giveaway and help-request coexistence

Suggested Implementation

1. Add a content type enum for Giveaway vs HelpRequest
2. Use (content_type, target_id, user) and (content_type, target_id) in governance storage
3. Require callers to specify content type when flagging and querying
4. Add regression tests proving same numeric IDs no longer collide

Acceptance Criteria

• Flagging a help request cannot affect a giveaway with the same numeric ID
• Flag counts are isolated per content type
• Auto-suspension resolves the intended content item only

Submission Guidelines

• Branch: fix/governance-flag-namespacing
• Depends on: None
• PR: fix(governance): namespace flags by content type to prevent id collisions

[Awointa]

Hi, I’d like to work on this issue. I can namespace governance flags and counts by content type so giveaways and help requests with the same numeric ID remain fully isolated. I’ll update the storage keys and affected governance methods, add the required content-type handling, and write regression tests covering same-ID coexistence, isolated counts, and correct auto-suspension behavior.

[mxrtins04]

Hi maintainer, can i be assigned this issue pleasee?

[Copstud3]

I'd like to take on this issue. The root cause is clear — FlagRecord(u64, Address) and FlagCount(u64) key flags solely by numeric ID, making collisions between giveaways and help requests sharing the same ID inevitable. My approach would be to introduce a ContentType enum (with Giveaway and HelpRequest variants), update the storage keys to FlagRecord(ContentType, u64, Address) and FlagCount(ContentType, u64), and thread the content_type parameter through flag_content, get_flag_count, has_flagged, and auto_suspend so every operation resolves against the correct content type explicitly. I'll also add regression tests in test.rs that seed a giveaway and a help request with the same numeric ID, flag one, and assert the other's flag count remains zero — directly covering the acceptance criteria. I'm comfortable working in Rust and can open the PR against fix/governance-flag-namespacing following the submission guidelines.

[grantfox-oss]

🦊 GrantFox — @Copstud3 has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #411)
2. Your PR will be reviewed by the geevapp maintainers

Good luck! Track your progress on GrantFox.