Merge pull request #259 from fedspendingtransparency/fix/DEV14466

DEV-14466 fix tooltip wrapper on download button

Author: jdhfrb

components/DownloadIconButton.jsx

@@ -1,3 +1,4 @@
+/* eslint-disable jsx-a11y/no-interactive-element-to-noninteractive-role */
 /**
  * DownloadIconButton.jsx
  * Created by Lizzie Salita 7/9/20
@@ -47,14 +48,13 @@ const DownloadIconButton = ({
                 tooltipComponent={tooltipComponent}>
                 <button
                     type="button"
+                    role="presentation"
                     className="usda-button"
                     title={buttonText}
-                    aria-label={buttonText}
                     disabled={downloadInFlight || !isEnabled}
                     onClick={startDownload}
                     style={{ backgroundColor }}
-                    tabIndex={!isEnabled ? -1 : 0}
-                    aria-hidden={!isEnabled}>
+                    tabIndex={!isEnabled ? -1 : 0}>
                     <FontAwesomeIcon icon={icon} spin={downloadInFlight} color="#dfe1e2" />
                     <span style={{ color: '#dfe1e2' }}>{buttonText}</span>
                 </button>
@@ -82,4 +82,4 @@ const DownloadIconButton = ({
 
 DownloadIconButton.displayName = 'Download Icon Button';
 DownloadIconButton.propTypes = propTypes;
-export default DownloadIconButton;
+export default DownloadIconButton;

components/infoTooltip/TooltipWrapper.jsx

@@ -1,3 +1,4 @@
+/* eslint-disable jsx-a11y/no-noninteractive-tabindex */
 /**
  * Tooltip.jsx
  * Created by Lizzie Salita 3/8/19
@@ -307,9 +308,8 @@ const TooltipWrapper = ({
                     tooltipContainer.current = div;
                 }}>
                 <div
-                    role="button"
+                    role="presentation"
                     tabIndex="0"
-                    aria-label="Tooltip Hover Wrapper"
                     className="tooltip__hover-wrapper"
                     onBlur={closeTooltip}
                     onFocus={showTooltipFunc}

dist/index.js

@@ -623,8 +623,8 @@
 
       import './mocker-runtime-injected.js';
 
-      import './runtime~main.1a60110c.iframe.bundle.js';
+      import './runtime~main.f016f9f4.iframe.bundle.js';
 
       import './6094.566847d9.iframe.bundle.js';
 
-      import './main.9bb1fb29.iframe.bundle.js';</script></body></html>
+      import './main.1c40801a.iframe.bundle.js';</script></body></html>

docs/148.561ea147.iframe.bundle.js

@@ -1 +1 @@
-{"generatedAt":1769798171433,"userSince":1751563499910,"hasCustomBabel":false,"hasCustomWebpack":true,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{"@babel/plugin-transform-optional-chaining":"7.27.1","@chromatic-com/storybook":"4.1.1","@testing-library/jest-dom":"6.8.0","@testing-library/react":"14.0.0","eslint-plugin-jasmine":"2.10.1","jest":"28.1.3","jest-cli":"28.1.3"},"hasRouterPackage":false,"packageManager":{"type":"npm","agent":"npm","nodeLinker":"node_modules"},"typescriptOptions":{"reactDocgen":"react-docgen-typescript"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/react-webpack5","options":{}},"builder":"@storybook/builder-webpack5","renderer":"@storybook/react","portableStoriesFileCount":2,"applicationFileCount":9,"storybookVersion":"9.1.3","language":"typescript","storybookPackages":{"@storybook/addon-a11y":{"version":"9.1.3"},"@storybook/react-webpack5":{"version":"9.1.3"},"storybook":{"version":"9.1.3"}},"addons":{"@storybook/addon-links":{"version":"9.1.3"},"@storybook/addon-webpack5-compiler-babel":{"version":"3.0.6"},"@chromatic-com/storybook":{"version":"4.1.1"},"@storybook/addon-docs":{"version":"9.1.3"},"@storybook/addon-styling-webpack":{"version":"2.0.0"}}}
+{"generatedAt":1771456697493,"userSince":1747848640087,"hasCustomBabel":false,"hasCustomWebpack":true,"hasStaticDirs":false,"hasStorybookEslint":false,"refCount":0,"testPackages":{"@babel/plugin-transform-optional-chaining":"7.27.1","@chromatic-com/storybook":"4.1.1","@testing-library/jest-dom":"6.8.0","@testing-library/react":"14.0.0","eslint-plugin-jasmine":"2.10.1","jest":"28.1.3","jest-cli":"28.1.3"},"hasRouterPackage":false,"packageManager":{"type":"npm","agent":"npm","nodeLinker":"node_modules"},"typescriptOptions":{"reactDocgen":"react-docgen-typescript"},"preview":{"usesGlobals":false},"framework":{"name":"@storybook/react-webpack5","options":{}},"builder":"@storybook/builder-webpack5","renderer":"@storybook/react","portableStoriesFileCount":5,"applicationFileCount":9,"storybookVersion":"9.1.3","language":"typescript","storybookPackages":{"@storybook/addon-a11y":{"version":"9.1.3"},"@storybook/react-webpack5":{"version":"9.1.3"},"storybook":{"version":"9.1.3"}},"addons":{"@storybook/addon-links":{"version":"9.1.3"},"@storybook/addon-webpack5-compiler-babel":{"version":"3.0.6"},"@chromatic-com/storybook":{"version":"4.1.1"},"@storybook/addon-docs":{"version":"9.1.3"},"@storybook/addon-styling-webpack":{"version":"2.0.0"}}}