Skip to content

Add search support to Services #59

Description

@AnonymousXC

Current Working

The Services view (and Service Types view) currently does not has a search feature. As registries grow, this will become a performance and UX problem. Search needs to be added.

Backwards-compatible approach

  1. Accept one optional query parameters on GET /services - search
  2. When search parameter is not provided, return all results or the full json(as the current response).
  3. When search parameters are present, return the response as the search result( if page parameter present then the new response else the old response).
  4. Return empty response if search result not found.

Input sanitization

  • Strip and normalize whitespace
  • Enforce search query length limits
  • Validate against an allowlist of safe characters using regex(no special characters allowed, eg - <,>, * and etc)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions