Enable AOT and platform compatibility analyzers. (#340)

* Mark unmanaged reader/writer APIs as supported only on Windows.

* Enable AOT compatibility analyzer.

This required to add a trim-friendly version of the COM registry activation path.

* Use `ComInterfaceMarshaller` as marshaller.

* Add `dotnet11` NuGet feed.

* Suppress platform compatibility warnings for test code that already runs only on Windows.

* Update src/Microsoft.DiaSymReader/SymUnmanagedFactory.cs

* Revert "Update src/Microsoft.DiaSymReader/SymUnmanagedFactory.cs"

This reverts commit 8ecedb2.

* Do not check for negative `HRESULT`.

Author: teo-tsirpanis

NuGet.config

@@ -5,6 +5,7 @@
     <add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
     <add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
     <add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
+    <add key="dotnet11" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" />
   </packageSources>
   <disabledPackageSources>
     <clear />

src/Microsoft.DiaSymReader.Native.Tests/SymUnmanagedFactoryNativeTests.cs

@@ -2,6 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the License.txt file in the project root for more information.
 
+// Tests are skipped on non-Windows already.
+#pragma warning disable CA1416 // Validate platform compatibility
+
 using System;
 using System.IO;
 using Microsoft.DiaSymReader.Tools;

src/Microsoft.DiaSymReader.Tests/SymUnmanagedFactoryTests.cs

@@ -1,7 +1,10 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the License.txt file in the project root for more information.
 
+// Tests are skipped on non-Windows already.
+#pragma warning disable CA1416 // Validate platform compatibility
+
 using System;
 using System.IO;
 using System.Reflection;

src/Microsoft.DiaSymReader.Tests/SymUnmanagedWriterTests.cs

@@ -2,6 +2,9 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the License.txt file in the project root for more information.
 
+// Tests are skipped on non-Windows already.
+#pragma warning disable CA1416 // Validate platform compatibility
+
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;

src/Microsoft.DiaSymReader/Microsoft.DiaSymReader.csproj

@@ -8,6 +8,7 @@
     <Description>Microsoft DiaSymReader interop interfaces and utilities.</Description>
     <PackageReleaseNotes>Microsoft DiaSymReader interop interfaces and utilities</PackageReleaseNotes>
     <PackageTags>DiaSymReader ISymUnmanagedReader PDB COM interop debugging</PackageTags>
+    <IsAotCompatible Condition="'$(TargetFramework)' == '$(NetCurrent)'">true</IsAotCompatible>
   </PropertyGroup>
 
   <ItemGroup>

src/Microsoft.DiaSymReader/Reader/SymUnmanagedReaderFactory.cs

@@ -8,6 +8,9 @@
 
 namespace Microsoft.DiaSymReader
 {
+#if NET
+    [System.Runtime.Versioning.SupportedOSPlatform("windows")]
+#endif
     public static class SymUnmanagedReaderFactory
     {
         /// <summary>

src/Microsoft.DiaSymReader/SymUnmanagedFactory.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
@@ -21,6 +21,9 @@
 
 namespace Microsoft.DiaSymReader
 {
+#if NET
+    [System.Runtime.Versioning.SupportedOSPlatform("windows")]
+#endif
     internal static partial class SymUnmanagedFactory
     {
         private const string AlternativeLoadPathEnvironmentVariableName = "MICROSOFT_DIASYMREADER_NATIVE_ALT_LOAD_PATH";
@@ -40,7 +43,11 @@ internal static partial class SymUnmanagedFactory
         // CorSymReader_SxS from corsym.idl
         private const string SymReaderClsid = "0A3976C5-4529-4ef8-B0B0-42EED37082CD";
 
+#if NET
+        private const string IUnknownIid = "00000000-0000-0000-C000-000000000046";
+#else
         private static Type s_lazySymReaderComType, s_lazySymWriterComType;
+#endif
 
         internal static string DiaSymReaderModuleName
             => RuntimeInformation.ProcessArchitecture switch
@@ -99,6 +106,11 @@ internal static string DiaSymReaderModuleName
         private delegate void NativeFactory(ref Guid id, [MarshalAs(UnmanagedType.IUnknown)] out object instance);
 #endif
 
+#if NET
+        [LibraryImport("Ole32")]
+        private static unsafe partial int CoCreateInstance(in Guid rclsid, void* pUnkOuter, int dwClsContext, in Guid riid, [MarshalUsing(typeof(ComInterfaceMarshaller<object>))] out object ppObj);
+#endif
+
         // internal for testing
         internal static string GetEnvironmentVariable(string name)
         {
@@ -140,7 +152,7 @@ private static unsafe object TryLoadFromAlternativePath(Guid clsid, bool createR
                 var creator = Marshal.GetDelegateForFunctionPointer<NativeFactory>(createAddress);
                 creator(ref clsid, out instance);
 #else
-                var creator = (delegate*unmanaged<Guid*, IntPtr*, void>)createAddress;
+                var creator = (delegate* unmanaged<Guid*, IntPtr*, void>)createAddress;
                 IntPtr rawInstance = default;
                 creator(&clsid, &rawInstance);
                 instance = createReader
@@ -159,22 +171,24 @@ private static unsafe object TryLoadFromAlternativePath(Guid clsid, bool createR
             return instance;
         }
 
-        private static Type GetComTypeType(ref Type lazyType, Guid clsid)
+#if NET
+        private static unsafe object ActivateClass(Guid clsid)
         {
-            if (lazyType == null)
+            int hr = CoCreateInstance(in clsid, null, 1, new Guid(IUnknownIid), out object instance);
+            Marshal.ThrowExceptionForHR(hr);
+            return instance;
+        }
+#else
+        private static object ActivateClass(ref Type lazyType, Guid clsid)
+        {
+            if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
             {
-                if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-                {
-                    lazyType = Marshal.GetTypeFromCLSID(clsid);
-                }
-                else
-                {
-                    throw new NotSupportedException("COM lookup is not supported");
-                }
+                throw new PlatformNotSupportedException("COM lookup is not supported");
             }
-
-            return lazyType;
+            lazyType ??= Marshal.GetTypeFromCLSID(clsid);
+            return Activator.CreateInstance(lazyType);
         }
+#endif
 
         internal static unsafe object CreateObject(bool createReader, bool useAlternativeLoadPath, bool useComRegistry, out string moduleName, out Exception loadException)
         {
@@ -265,11 +279,11 @@ internal static unsafe object CreateObject(bool createReader, bool useAlternativ
                 // Try to find a registered CLR implementation
                 try
                 {
-                    var comType = createReader ?
-                        GetComTypeType(ref s_lazySymReaderComType, clsid) :
-                        GetComTypeType(ref s_lazySymWriterComType, clsid);
-
-                    instance = Activator.CreateInstance(comType);
+#if NET
+                    instance = ActivateClass(clsid);
+#else
+                    instance = ActivateClass(ref createReader ? ref s_lazySymReaderComType : ref s_lazySymWriterComType, clsid);
+#endif
                     moduleName = LegacyDiaSymReaderModuleName;
                 }
                 catch (Exception e)
@@ -281,6 +295,5 @@ internal static unsafe object CreateObject(bool createReader, bool useAlternativ
 
             return instance;
         }
-
     }
 }

src/Microsoft.DiaSymReader/Writer/SymUnmanagedWriterFactory.cs

@@ -7,6 +7,9 @@
 
 namespace Microsoft.DiaSymReader
 {
+#if NET
+    [System.Runtime.Versioning.SupportedOSPlatform("windows")]
+#endif
     public static class SymUnmanagedWriterFactory
     {
         /// <summary>