Compilation error in Math functions

[abhinavdhere]

CGAL is now available through snap package on Ubuntu 18.04 and thus problem of CGAL dependency is resolved. On running the CMakeLists.txt after commenting the error message for CGAL, the configure works. On running make, however, I get the following errors,

`Scanning dependencies of target retiler
[ 7%] Building CXX object CMakeFiles/retiler.dir/src/Mesh.cpp.o
[ 15%] Building CXX object CMakeFiles/retiler.dir/src/MeshEx.cpp.o
In file included from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:0:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:157:211: error: cannot bind non-const lvalue reference of type ‘std::vector<std::pair<math::Vec3, math::Vec2 > >&’ to an rvalue of type ‘std::vector<std::pair<math::Vec3, math::Vec2 > >’
vector<std::pair<math::Vec3f, math::Vec2f> > &interiorPoints = std::vector<std::pair<math::Vec3f, math::Vec2f> >() );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘MeshEx::Edge* MeshEx::Triangle::getEdge(MeshEx::Vertex*, MeshEx::Vertex*)’:

/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1102:9: error: cannot convert ‘bool’ to ‘MeshEx::Edge*’ in return
return false;
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsPlane(const Vec3f&, const float&, math::Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1303:43: error: ‘Ray3d’ is not a member of ‘math’
return math::intersectionRayPlane( math::Ray3d( v1->position, v2->position ), normal, distance, intersectionPoint );
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1303:43: note: suggested alternative: ‘Ray3f’

return math::intersectionRayPlane( math::Ray3d( v1->position, v2->position ), normal, distance, intersectionPoint );
^~~~~
Ray3f
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsLine(const Vec3f&, const Vec3f&, math::Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:41: error: ‘Ray3d’ is not a member of ‘math’

return math::intersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersectionPoint );
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:41: note: suggested alternative: ‘Ray3f’
return math::intersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersectionPoint );
^~~~~
Ray3f
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:84: error: ‘Ray3d’ is not a member of ‘math’
ntersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersectionPoint );
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:84: note: suggested alternative: ‘Ray3f’
ntersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersectionPoint );
^~~~~
Ray3f
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsLine(const Vec3f&, const Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:41: error: ‘Ray3d’ is not a member of ‘math’
return math::intersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersection );
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:41: note: suggested alternative: ‘Ray3f’
return math::intersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersection );
^~~~~
Ray3f
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:84: error: ‘Ray3d’ is not a member of ‘math’
ntersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersection );
^~~~~
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:84: note: suggested alternative: ‘Ray3f’
ntersectionRayRay( math::Ray3d( v1->position, v2->position ), math::Ray3d( p1, p2 ), intersection );
^~~~~
Ray3f
CMakeFiles/retiler.dir/build.make:86: recipe for target 'CMakeFiles/retiler.dir/src/MeshEx.cpp.o' failed
make[2]: *** [CMakeFiles/retiler.dir/src/MeshEx.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/retiler.dir/all' failed
make[1]: *** [CMakeFiles/retiler.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2`

[abhinavdhere]

For the first issue of binding lvalue to rvalue, changing line 157 to
void retriangulateHole( std::vector<MeshEx::Edge *> &boundaryEdges, std::map<MeshEx::Vertex *, math::Vec2f> &boundaryVertexProjections, std::vector<std::pair<math::Vec3f, math::Vec2f> >const &interiorPoints = std::vector<std::pair<math::Vec3f, math::Vec2f> >() );

(added const keyword)

changes the error log to

`[ 7%] Building CXX object CMakeFiles/retiler.dir/src/MeshEx.cpp.o
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘MeshEx::Edge* MeshEx::Triangle::getEdge(MeshEx::Vertex*, MeshEx::Vertex*)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1102:9: error: cannot convert ‘bool’ to ‘MeshEx::Edge*’ in return
return false;
^~~~~

/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsPlane(const Vec3f&, const float&, math::Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1303:77: error: no matching function for call to ‘math::Ray3::Ray3(math::Vec3f&, math::Vec3f&)’
return math::intersectionRayPlane( math::Ray3f( v1->position, v2->position ), normal, distance, intersectionPoint );
^
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate: math::Ray3::Ray3(const math::Vec3&, const math::Vec3&, const T&, const T&) [with T = float]
Ray3::Ray3( const math::Vec3 &origin, const math::Vec3 &direction, const T &_tmin, const T &_tmax ) : o(origin), d(direction), tmin(_tmin), tmax(_tmax)
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate expects 4 arguments, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate: math::Ray3::Ray3() [with T = float]
Ray3::Ray3() : tmin(0.0f), tmax(std::numeric_limits::max())
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate expects 0 arguments, 2 provided
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(const math::Ray3&)
class Ray3
^~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(math::Ray3&&)
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsLine(const Vec3f&, const Vec3f&, math::Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:75: error: no matching function for call to ‘math::Ray3::Ray3(math::Vec3f&, math::Vec3f&)’
return math::intersectionRayRay( math::Ray3f( v1->position, v2->position ), math::Ray3f( p1, p2 ), intersectionPoint );
^
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate: math::Ray3::Ray3(const math::Vec3&, const math::Vec3&, const T&, const T&) [with T = float]
Ray3::Ray3( const math::Vec3 &origin, const math::Vec3 &direction, const T &_tmin, const T &_tmax ) : o(origin), d(direction), tmin(_tmin), tmax(_tmax)
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate expects 4 arguments, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate: math::Ray3::Ray3() [with T = float]
Ray3::Ray3() : tmin(0.0f), tmax(std::numeric_limits::max())
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate expects 0 arguments, 2 provided
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(const math::Ray3&)
class Ray3
^~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(math::Ray3&&)
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1311:98: error: no matching function for call to ‘math::Ray3::Ray3(const Vec3f&, const Vec3f&)’
return math::intersectionRayRay( math::Ray3f( v1->position, v2->position ), math::Ray3f( p1, p2 ), intersectionPoint );
^
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate: math::Ray3::Ray3(const math::Vec3&, const math::Vec3&, const T&, const T&) [with T = float]
Ray3::Ray3( const math::Vec3 &origin, const math::Vec3 &direction, const T &_tmin, const T &_tmax ) : o(origin), d(direction), tmin(_tmin), tmax(_tmax)
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate expects 4 arguments, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate: math::Ray3::Ray3() [with T = float]
Ray3::Ray3() : tmin(0.0f), tmax(std::numeric_limits::max())
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate expects 0 arguments, 2 provided
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(const math::Ray3&)
class Ray3
^~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(math::Ray3&&)
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp: In member function ‘bool MeshEx::Edge::intersectsLine(const Vec3f&, const Vec3f&)’:
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:75: error: no matching function for call to ‘math::Ray3::Ray3(math::Vec3f&, math::Vec3f&)’
return math::intersectionRayRay( math::Ray3f( v1->position, v2->position ), math::Ray3f( p1, p2 ), intersection );
^
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate: math::Ray3::Ray3(const math::Vec3&, const math::Vec3&, const T&, const T&) [with T = float]
Ray3::Ray3( const math::Vec3 &origin, const math::Vec3 &direction, const T &_tmin, const T &_tmax ) : o(origin), d(direction), tmin(_tmin), tmax(_tmax)
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate expects 4 arguments, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate: math::Ray3::Ray3() [with T = float]
Ray3::Ray3() : tmin(0.0f), tmax(std::numeric_limits::max())
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate expects 0 arguments, 2 provided
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(const math::Ray3&)
class Ray3
^~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(math::Ray3&&)
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:1322:98: error: no matching function for call to ‘math::Ray3::Ray3(const Vec3f&, const Vec3f&)’
return math::intersectionRayRay( math::Ray3f( v1->position, v2->position ), math::Ray3f( p1, p2 ), intersection );
^
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate: math::Ray3::Ray3(const math::Vec3&, const math::Vec3&, const T&, const T&) [with T = float]
Ray3::Ray3( const math::Vec3 &origin, const math::Vec3 &direction, const T &_tmin, const T &_tmax ) : o(origin), d(direction), tmin(_tmin), tmax(_tmax)
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:45:2: note: candidate expects 4 arguments, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate: math::Ray3::Ray3() [with T = float]
Ray3::Ray3() : tmin(0.0f), tmax(std::numeric_limits::max())
^~~~~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:39:2: note: candidate expects 0 arguments, 2 provided
In file included from /home/abhinav/Documents/My Profile/retiler/src/math/Math.h:28:0,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.h:9,
from /home/abhinav/Documents/My Profile/retiler/src/MeshEx.cpp:2:
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(const math::Ray3&)
class Ray3
^~~~
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate: constexpr math::Ray3::Ray3(math::Ray3&&)
/home/abhinav/Documents/My Profile/retiler/src/math/Ray3.h:22:8: note: candidate expects 1 argument, 2 provided
CMakeFiles/retiler.dir/build.make:86: recipe for target 'CMakeFiles/retiler.dir/src/MeshEx.cpp.o' failed
make[2]: *** [CMakeFiles/retiler.dir/src/MeshEx.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/retiler.dir/all' failed
make[1]: *** [CMakeFiles/retiler.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
`