Crontab breaks on single quotes in either a command or a comment line

[silentvick]

Deployer Version

v7.5.12

Target OS

Ubuntu 22.04

Which PHP version are you using?

PHP 7.4

Content of deploy.php or deploy.yaml

require 'contrib/crontab.php';

after('deploy:success', 'crontab:sync');

add('crontab:jobs', [
    // Notice the single quote
    '0 0 * * * echo "It\'s deploy time"',
]);

// just run crontab:sync then

Steps to reproduce

If either a command or a comment contains a single quote, the task will fail with shell error. Moreover a standard crontab template already has a help comment that contains single quotes (at least on Ubuntu):

# To define the time you can provide concrete values for
# minute (m), hour (h), day of month (dom), month (mon),
# and day of week (dow) or use '*' in these fields (for 'any').
#
# Notice that tasks will be started based on the cron's system
# daemon's notion of time and timezones.

Which leads to this error on creating temporary template:

[hostname] run echo '# Notice that tasks will be started based on the cron's system' >> /tmp/crontab_save_67d7e5e30bd29
[hostname] bash: line 1: unexpected EOF while looking for matching `''
[hostname] bash: line 2: syntax error: unexpected end of file
[hostname]  error  in crontab.php on line 98:
[hostname] exit code -1 (Unknown error)

Seems like the content is echo-ed without proper escaping, so there might be other errors because of that.

[silentvick]

I went ahead and opened a PR #4042

[silentvick]

Since PR was merged, I'll mark the thread as answered. One question though. Will it be merged into 7.x branch as well or do I need to open a PR against it, what's the process here? We are on PHP7, so can't use the latest version of the package 🤷

[antonmedv]

We can merge it to v7 as well. But soon it will be only readonly branch.

[silentvick]

Would be nice, thanks!

[antonmedv]

Please, create PR for v7 branch.

[silentvick]

Please, create PR for v7 branch.

Opened it: #4046