Parse self.<var> outputs correctly. Closes #1815 (#1890)

Author: brollb

src/common/OperationCode.js

@@ -408,10 +408,14 @@ var isNodeJs = typeof module === 'object' && module.exports;
         schema.methods[name].outputs = retVals
             .filter(node => !!node)
             .map((arg, index) => {
-                var isNameNode = OperationCode.isNodeType(arg, 'Name');
-                var name = isNameNode ? arg.id.v : 'result';
-                if (!isNameNode && index > 0) {
-                    name += '_' + index;
+                let name = index > 0 ? `result_${index}` : 'result';
+                const isNameNode = OperationCode.isNodeType(arg, 'Name');
+                const isSelfAttr = OperationCode.isNodeType(arg, 'Attribute') &&
+                    arg.value.id.v === 'self';
+                if (isNameNode) {
+                    name = arg.id.v;
+                } else if (isSelfAttr) {
+                    name = arg.attr.v;
                 }
 
                 var value = OperationCode.isNodeType(arg, 'Num') ? arg.n.v : name;

test/unit/common/OperationCode.spec.js

@@ -226,6 +226,13 @@ describe('OperationCode', function() {
                 assert.deepEqual(operation.getOutputs().map(output => output.name), names);
             });
 
+            it('should parse the output name when returning attr', async function() {
+                const code = testCase('op-output-name.py');
+                const operation = new OperationCode(code);
+                const names = ['myOutput'];
+                assert.deepEqual(operation.getOutputs().map(output => output.name), names);
+            });
+
             it.skip('should parse the output types', function() {
                 const types = ['str', 'int'];
                 assert.deepEqual(operation.getOutputs().map(output => output.type), types);

test/unit/test-cases/operations/op-output-name.py

@@ -0,0 +1,8 @@
+from operations import Operation
+from typing import Tuple
+
+class ExampleOperation(Operation):
+
+    def execute(hello, world, count):
+        self.myOutput = hello + world
+        return self.myOutput