Skip to content

Commit 8fa1331

Browse files
committed
fix: avoid default write path scroll probes
Change-Id: I58ddd0c9825b6d0c90ddfd965e35e2a4a9a1814b Signed-off-by: Thomas Kosiewski <tk@coder.com>
1 parent 82e2fd7 commit 8fa1331

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎lib/terminal.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -571,13 +571,13 @@ export class Terminal implements ITerminalCore {
571571

572572
const savedViewportY = this.viewportY;
573573
const savedTargetViewportY = this.targetViewportY;
574-
const savedScrollbackLength = this.getScrollbackLength();
575-
const wasAlternateScreen = this.wasmTerm!.isAlternateScreen();
576-
const shouldPreserveScroll =
574+
const preserveCandidate =
577575
this.options.preserveScrollOnWrite &&
578576
Math.floor(savedViewportY) > 0 &&
579-
Math.floor(savedTargetViewportY) > 0 &&
580-
!wasAlternateScreen;
577+
Math.floor(savedTargetViewportY) > 0;
578+
const wasAlternateScreen = preserveCandidate ? this.wasmTerm!.isAlternateScreen() : false;
579+
const shouldPreserveScroll = preserveCandidate && !wasAlternateScreen;
580+
const savedScrollbackLength = shouldPreserveScroll ? this.getScrollbackLength() : 0;
581581
const savedCursorX = shouldPreserveScroll ? this.wasmTerm!.getCursor().x : 0;
582582
const preserveScrollAnchor = shouldPreserveScroll
583583
? this.createPreserveScrollAnchor(savedViewportY)

0 commit comments

Comments
 (0)