Skip to content

Commit 3da2136

Browse files
committed
Fix Typescript extension not loading
1 parent 8ff1e2e commit 3da2136

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ Code v1.141.0
3030
workbench storage on the remote server instead of browser storage. Use this if
3131
you want to share storage between multiple devices.
3232

33+
### Fixed
34+
35+
- The Typescript extension was trying to load as a browser extension even though
36+
we build the remote server version, causing it to fail to activate.
37+
3338
### Changed
3439

3540
- Update to Code 1.141.0

‎ci/build/build-vscode.sh‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,17 @@ main() {
5858
exit 1
5959
fi
6060

61-
# Add the date, our name, links, enable telemetry (this just makes telemetry
62-
# available; telemetry can still be disabled by flag or setting), and
63-
# configure trusted extensions (since some, like github.copilot-chat, never
64-
# ask to be trusted and this is the only way to get auth working).
61+
# Modify the product.json:
62+
# - Add the date
63+
# - Set the code-server name.
64+
# - Add our links
65+
# - Enable telemetry (this just makes telemetry available; telemetry can still
66+
# be disabled by flag or setting)
67+
# - Configure trusted extensions (since some, like github.copilot-chat, never
68+
# ask to be trusted and this is the only way to get auth working).
69+
# - Make Typescript server plugins run in the workspace. We build the remote
70+
# server version, so there is no browser distribution, and this key is not
71+
# added automatically.
6572
#
6673
# This needs to be done before building as Code will read this file and embed
6774
# it into the client-side code.
@@ -103,6 +110,9 @@ main() {
103110
],
104111
"aiConfig": {
105112
"ariaKey": "code-server"
113+
},
114+
"extensionPointExtensionKind": {
115+
"typescriptServerPlugins": ["workspace"]
106116
}
107117
}
108118
EOF

0 commit comments

Comments
 (0)