Skip to content

Commit a55b6d7

Browse files
committed
[workflows] release strategy edge broke semver tagging releases.
We don't use the edge label activly anyway. Also force usage of AppVersion as image version since it seem to fallback using latest ever if overriden via helm.
1 parent dd9145b commit a55b6d7

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

.github/workflows/container-registry-ghcr.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
name: Container Registry GHCR
1010
"on":
1111
push:
12-
branches:
13-
- main
12+
tags:
13+
- '*'
1414
workflow_dispatch: {}
1515
permissions:
1616
contents: read
@@ -34,8 +34,6 @@ jobs:
3434
with:
3535
images: ghcr.io/${{ github.repository }}
3636
tags: |
37-
# https://github.com/docker/metadata-action#typeedge
38-
type=edge
3937
# https://github.com/docker/metadata-action#latest-tag
4038
type=raw,value=latest,enable={{is_default_branch}}
4139
# https://github.com/docker/metadata-action#typesemver

Makefile.maker.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ githubWorkflow:
4141
enabled: true
4242
platforms: "linux/amd64,linux/arm64"
4343
tagStrategy:
44-
- edge
4544
- latest
4645
- semver
4746
- sha

charts/openstack-hypervisor-operator/templates/deployment.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ spec:
4747
value: {{ quote .Values.controllerManager.manager.env.labelSelector }}
4848
- name: KUBERNETES_CLUSTER_DOMAIN
4949
value: {{ quote .Values.kubernetesClusterDomain }}
50-
image: {{ .Values.controllerManager.manager.image.repository }}:{{ .Values.controllerManager.manager.image.tag
51-
| default .Chart.AppVersion }}
50+
image: {{ .Values.controllerManager.manager.image.repository }}:{{ .Chart.AppVersion }}
5251
livenessProbe:
5352
httpGet:
5453
path: /healthz

0 commit comments

Comments
 (0)