Skip to content

Commit 7e85176

Browse files
committed
Replace deprecated scheme.Builder with runtime.SchemeBuilder
controller-runtime v0.24.0 deprecated scheme.Builder in favor of using k8s.io/apimachinery's runtime.SchemeBuilder directly, as API packages should minimize their dependency footprint.
1 parent b9d537c commit 7e85176

5 files changed

Lines changed: 20 additions & 6 deletions

File tree

api/v1/eviction_types.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package v1
1919

2020
import (
2121
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
22+
"k8s.io/apimachinery/pkg/runtime"
2223
)
2324

2425
// EvictionSpec defines the desired state of Eviction
@@ -112,5 +113,8 @@ type EvictionList struct {
112113
}
113114

114115
func init() {
115-
SchemeBuilder.Register(&Eviction{}, &EvictionList{})
116+
SchemeBuilder.Register(func(scheme *runtime.Scheme) error {
117+
scheme.AddKnownTypes(GroupVersion, &Eviction{}, &EvictionList{})
118+
return nil
119+
})
116120
}

api/v1/groupversion_info.go

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,26 @@ limitations under the License.
2323
package v1
2424

2525
import (
26+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
27+
"k8s.io/apimachinery/pkg/runtime"
2628
"k8s.io/apimachinery/pkg/runtime/schema"
27-
"sigs.k8s.io/controller-runtime/pkg/scheme"
2829
)
2930

3031
var (
3132
// GroupVersion is group version used to register these objects
3233
GroupVersion = schema.GroupVersion{Group: "kvm.cloud.sap", Version: "v1"}
3334

3435
// SchemeBuilder is used to add go types to the GroupVersionKind scheme
35-
SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}
36+
SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)
3637

3738
// AddToScheme adds the types in this group-version to the given scheme.
3839
AddToScheme = SchemeBuilder.AddToScheme
3940

4041
// Workaround: https://github.com/kubernetes-sigs/controller-tools/issues/1193
4142
SchemeGroupVersion = GroupVersion
4243
)
44+
45+
func addKnownTypes(scheme *runtime.Scheme) error {
46+
metav1.AddToGroupVersion(scheme, GroupVersion)
47+
return nil
48+
}

api/v1/hypervisor_types.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ package v1
2020
import (
2121
"k8s.io/apimachinery/pkg/api/resource"
2222
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
23+
"k8s.io/apimachinery/pkg/runtime"
2324
)
2425

2526
// ResourceName is the name identifying a hypervisor resource.
@@ -598,5 +599,8 @@ type HypervisorList struct {
598599
}
599600

600601
func init() {
601-
SchemeBuilder.Register(&Hypervisor{}, &HypervisorList{})
602+
SchemeBuilder.Register(func(scheme *runtime.Scheme) error {
603+
scheme.AddKnownTypes(GroupVersion, &Hypervisor{}, &HypervisorList{})
604+
return nil
605+
})
602606
}

api/v1/zz_generated.deepcopy.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

charts/openstack-hypervisor-operator/crds/kvm.cloud.sap_hypervisors.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ spec:
146146
(as used by PodSpec.volumes in core Kubernetes): exactly one
147147
type-specific sub-field must be populated per entry.
148148
149-
The Cortex Placement Shim and scheduler read group memberships
149+
The Cortex Placement shim and scheduler read group memberships
150150
directly from this field.
151151
152152
Note: uniqueness of trait names and aggregate UUIDs is not enforced

0 commit comments

Comments
 (0)