From 68ca69cc4b07df838f32245d301ef22a5392037e Mon Sep 17 00:00:00 2001 From: Emmanuel Ikwuoma Date: Wed, 13 May 2026 14:15:36 +0100 Subject: [PATCH 1/2] move config builder to unit test --- crates/remote-signer/src/client.rs | 26 -------------------------- crates/remote-signer/src/config.rs | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/crates/remote-signer/src/client.rs b/crates/remote-signer/src/client.rs index f9dbd0a..dca61af 100644 --- a/crates/remote-signer/src/client.rs +++ b/crates/remote-signer/src/client.rs @@ -394,30 +394,4 @@ mod integration_tests { } } } - - #[tokio::test] - async fn config_builder_pattern() { - let config = RemoteSigningConfig::default() - .with_timeout(Duration::from_secs(10)) - .with_retry_config(RetryConfig::new( - 2, - Duration::from_millis(50), - Duration::from_secs(1), - )); - - assert_eq!(config.endpoint, "http://0.0.0.0:10340"); - assert_eq!(config.timeout, Duration::from_secs(10)); - assert_eq!(config.retry_config.max_retries, 2); - } - - #[tokio::test] - async fn retry_config_validation() { - let retry_config = RetryConfig::new(5, Duration::from_millis(100), Duration::from_secs(10)) - .with_backoff_multiplier(1.5); - - assert_eq!(retry_config.max_retries, 5); - assert_eq!(retry_config.initial_backoff, Duration::from_millis(100)); - assert_eq!(retry_config.max_backoff, Duration::from_secs(10)); - assert_eq!(retry_config.backoff_multiplier, 1.5); - } } diff --git a/crates/remote-signer/src/config.rs b/crates/remote-signer/src/config.rs index be32259..2289b8c 100644 --- a/crates/remote-signer/src/config.rs +++ b/crates/remote-signer/src/config.rs @@ -203,4 +203,30 @@ mod tests { }; assert!(config.validate().is_ok()); } + + #[tokio::test] + async fn config_builder_pattern() { + let config = RemoteSigningConfig::default() + .with_timeout(Duration::from_secs(10)) + .with_retry_config(RetryConfig::new( + 2, + Duration::from_millis(50), + Duration::from_secs(1), + )); + + assert_eq!(config.endpoint, "http://0.0.0.0:10340"); + assert_eq!(config.timeout, Duration::from_secs(10)); + assert_eq!(config.retry_config.max_retries, 2); + } + + #[tokio::test] + async fn retry_config_validation() { + let retry_config = RetryConfig::new(5, Duration::from_millis(100), Duration::from_secs(10)) + .with_backoff_multiplier(1.5); + + assert_eq!(retry_config.max_retries, 5); + assert_eq!(retry_config.initial_backoff, Duration::from_millis(100)); + assert_eq!(retry_config.max_backoff, Duration::from_secs(10)); + assert_eq!(retry_config.backoff_multiplier, 1.5); + } } From 28900c9e417c2760a97bdcdd1b6475493b5a342b Mon Sep 17 00:00:00 2001 From: Emmanuel Ikwuoma Date: Tue, 19 May 2026 22:47:04 +0100 Subject: [PATCH 2/2] remove unneeded async in test --- crates/remote-signer/src/config.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/remote-signer/src/config.rs b/crates/remote-signer/src/config.rs index 2289b8c..a5814be 100644 --- a/crates/remote-signer/src/config.rs +++ b/crates/remote-signer/src/config.rs @@ -204,8 +204,8 @@ mod tests { assert!(config.validate().is_ok()); } - #[tokio::test] - async fn config_builder_pattern() { + #[test] + fn test_config_builder_pattern() { let config = RemoteSigningConfig::default() .with_timeout(Duration::from_secs(10)) .with_retry_config(RetryConfig::new( @@ -219,8 +219,8 @@ mod tests { assert_eq!(config.retry_config.max_retries, 2); } - #[tokio::test] - async fn retry_config_validation() { + #[test] + fn test_retry_config_validation() { let retry_config = RetryConfig::new(5, Duration::from_millis(100), Duration::from_secs(10)) .with_backoff_multiplier(1.5);