You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 751c1f7
Browse filesBrowse the repository at this point in the historyBrowse files
fix(eql): name stack-encrypt 0.2.0 and verify the feature from the packaged crate
The `stack-encrypt` feature depends on stack-encrypt by path and version.
Every in-tree job builds the path; the published crate resolves the
version from crates.io. The version said 0.1.0, which shipped without
`Describe`, `Description` and `Label` — so the feature compiled here and
could not compile for any consumer, or for docs.rs, which enables it.
Nothing noticed, because `cargo publish` verifies the default feature set
and this feature is off by default: the dry run in CI passed, and
release-plz would have published it.
Three changes close that. The requirement names 0.2.0, the version the
descriptor rework releases as (ad62087 on the base branch; cargo refuses
a requirement the in-tree path dependency does not satisfy, so the bump
had to land there first). The dry-run step and release-plz both pass
`--all-features`, so the verify builds the feature from the PACKAGED
manifest, where there is no path and stack-encrypt comes from the registry
— the build a consumer gets. And `release-plz.yml`'s eql-bindings job now
runs after the stack-* crates job: on a push that releases both, the crate
eql-bindings resolves exists by the time it looks.
The dry-run step is red until stack-encrypt 0.2.0 is on crates.io. That is
the true state of this branch, and it clears when #1050 merges and the
crates publish.
Found by the Codex review of #971 (the path dependency hid a registry
mismatch). Refs #1049.
0 commit comments